Fix or silence build warnings - #3
Merged
Merged
Conversation
crawfxrd
force-pushed
the
build-warnings
branch
2 times, most recently
from
October 14, 2021 14:18
828e859 to
c57768a
Compare
jackpot51
approved these changes
Oct 14, 2021
Member
Author
|
Should |
Member
|
@crawfxrd sure |
The flash example does the same thing as the main binary. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Add license information to files. Done with:
git ls-files src/ examples/ | xargs sed -i '1s,^,// SPDX-License-Identifier: MIT\n\n,'
Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
build-warnings
branch
from
October 14, 2021 15:46
c57768a to
654ad9a
Compare
Fix: - deprecated - clippy::clone_on_copy - clippy::if_then_panic - clippy::needless_borrow - clippy::println_empty_string - clippy::redundant_field_names Silence: - dead_code - clippy::new_without_default - clippy::len_without_is_empty - clippy::uninit_assumed_init Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
build-warnings
branch
from
October 14, 2021 16:11
654ad9a to
716e9b0
Compare
jacobgkau
approved these changes
Oct 14, 2021
jacobgkau
left a comment
jacobgkau
left a comment
Member
There was a problem hiding this comment.
Builds & flashes (tested on galp5 UMA).
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
Silence: