Skip to content

Update list - #247

Closed
ahoneybun wants to merge 4 commits into
system76:masterfrom
ahoneybun:update-model-list
Closed

ahoneybun wants to merge 4 commits into
system76:masterfrom
ahoneybun:update-model-list

Conversation

@ahoneybun

Copy link
Copy Markdown
Contributor

This PR does the following:

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Not officially release and not completed code

"Not officially release" is grammatically incorrect, and "not completed code" is very awkward. Try "Not completed or officially released" or just "Unofficial/incomplete".

@jacobgkau

Copy link
Copy Markdown
Member

image

It also looks like the asterisk needs to be escaped, otherwise it shows up as another list entry.

@jacobgkau

Copy link
Copy Markdown
Member

Can I ask why you went beyond the first commit? This list is preceded with These models are supported and followed by Other models may be in development or available without support, so it seems strange to include unsupported items in the list. I think the only reason these were in the list to begin with was because they were very nearly supported (PRs are still open/work is still ongoing.)

@crawfxrd

Copy link
Copy Markdown
Member

Technically, README.md.in is what should be updated. (The last commit to README.md would need to be synced as well in that case.)

@crawfxrd

Copy link
Copy Markdown
Member

Done in #260.

@crawfxrd crawfxrd closed this Dec 21, 2021
@ahoneybun
ahoneybun deleted the update-model-list branch September 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants