This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Conversation
sys27
force-pushed
the
feature/password-reset
branch
5 times, most recently
from
090161e to
e0f9b56
Compare
sys27
force-pushed
the
feature/password-reset
branch
from
e0f9b56 to
d81db1b
Compare
There was a problem hiding this comment.
Copilot reviewed 31 out of 46 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- Pyro.Api/Pyro/Endpoints/GitRepositoryEndpoints.cs: Evaluated as low risk
- Pyro.Api/Pyro/DtoMappings/IdentityMapper.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Models/OneTimePassword.cs: Evaluated as low risk
- Pyro.Api/Pyro.ApiTests/Clients/IdentityClient.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Shared/ServiceOptions.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Commands/NotifyExpiringPasswords.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/IPasswordService.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Models/OneTimePasswordPurpose.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Models/AuthenticationToken.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Models/User.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/PasswordService.cs: Evaluated as low risk
- Pyro.Api/Pyro.Domain.Identity/Models/AccessToken.cs: Evaluated as low risk
- Pyro.Api/Pyro/Endpoints/IssueEndpoints.cs: Evaluated as low risk
- Pyro.Api/Pyro.Contracts/Requests/Identity/ResetPasswordRequest.cs: Evaluated as low risk
- Pyro.Api/Pyro/Endpoints/IdentityEndpoints.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
Pyro.Api/Pyro.Domain.Identity.UnitTests/Models/UserTests.cs:523
- In the ResetPassword test, add assertions to verify that the user.Password and user.Salt are updated correctly and are not equal to their initial values before the reset.
user.ResetPassword(timeProvider, passwordService, oneTimePassword, password);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #270.