Null safety support

[it-sam]

No description provided.

[it-sam]

@synw Could you please check this out?

[neokree]

@duzenko Since synw is not very active on GitHub, could you please look at this pull request, and eventually deploy it on pub.dev?

Since there are 11 packages that depends on this one, they are having an hard time migrating to null-safety.

[duzenko]

@duzenko Since synw is not very active on GitHub, could you please look at this pull request, and eventually deploy it on pub.dev?

Since there are 11 packages that depends on this one, they are having an hard time migrating to null-safety.

I don't have write access

[it-sam]

By the time the pull request get approved,
There is an alternative.
Add this into your yaml file.

For Geo Json:

dependency_overrides:

  geojson:
    git:

      url: https://github.com/it-sam/geojson.git
  
      commit: 6fa3b9

For Geo point

  dependency_overrides:

  geopoint:

    git:

      url: https://github.com/it-sam/geopoint.git
  
      commit: 7a28e2

[synw]

Sorry for not being around these days. I should manage to take the time to merge these pull requests and publish to unlock the situation for you guys. Not doing Dart code since a while I am not confident about the null safety migrations, so I have a question: what version number should be the migrated version? Must we use something like 0.9.0-nullsafety.0 or directly upgrade to 1.0.0 or something? What is idiomatic?

[it-sam]

Hi Its fine to release with any version code. Thanks

On Fri, 25 Jun 2021 at 7:15 pm, synw ***@***.***> wrote: Sorry for not being around these days. I should manage to take the time to merge these pull requests and publish to unlock the situation for you guys. Not doing Dart code since a while I am not confident about the null safety migrations, so I have a question: what version number should be the migrated version? Must we use something like 0.9.0-nullsafety.0 or directly upgrade to 1.0.0 or something? What is idiomatic? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNI3RJPTIZBUR3B7RTAR3DTURFZ5ANCNFSM453TWD4Q> .

-- ------------------------------------- Thanks & Regards, Shyam Parmar +61 470298670 *Linkedin <https://www.linkedin.com/in/shyamparmar/>* | Blog <https://learning-alight.blogspot.com>

[neokree]

@synw I don't manage dart packages myself, but from what I can see from different packages published, versions with -nullsafety.0 suffix are commonly published as Pre-Release, and I think that pub would not use them unless explicitly defined.

Since the latest version available today is 0.8.0 and pub.dev follows the semantic versioning, your package is at this time in an initial development phase, so I think 0.9.0 is the right version.

However since the number of issues on this repo is basically 0 (except for this merge), and many projects are depending on it, I think it's also safe to release the next version as 1.0.0, to make it clear that it is stable, and in the future the changes would remain backward compatible, unless new features like null-safety are added, which it will require to increase to a new major version.

I hope my explanation will help you to decide on what version to apply

[synw]

@neokree thanks: we'll go for 1.0.0 then

@it-sam I am getting an error localy when running the tests after merging:

Cannot run with sound null safety, because the following dependencies
  don't support null safety:
  
   - package:intl

Did I miss something?

[it-sam]

Since Repo does not have .lock file it could be using old dependencies.
Try flutter pub upgrade
In my pubspec.lock I have intl 0.17.0 and it does support null safety.

intl:
dependency: transitive
description:
name: intl
url: "https://pub.dartlang.org"
source: hosted
version: "0.17.0"

If you are running the older version of flutter please upgrade by flutter upgrade
Also Try Flutter clean && flutter pub get

[synw]

You are right my install was completely outdated. Version 1.0.0 is published. Thanks for your work