[Feature request] Lyrics tab

[antoniosanchez-es]

The app currently lacks a lyrics screen, as opposed to the website.

I don't think it's currently being worked on, if that's not the case I'd be willing to take it on, I've already taken a look into the implementation.
Could I get approval to start?

[Ericgacoki]

@antoniosanchez-es

Could you please share your plan on how you're going to implement this feature?
We can do a quick brainstorm just so we are aligned.

Thanks!

[AntonioSanFer]

Hello! @Ericgacoki. I'll be using this account, I got them mixed up before, sorry for the confusion.

As far as I've seen it's just a matter of retrieving the lyrics preferences (plugin, auto download and override unsynced), then using the endpoints '/lyrics' or '/plugins/lyrics/search' if they don't exist locally and the preference is active.

The lyrics should come in an array with the format
{
text: string
time: number
}
which then should be mapped (LyricLine) and shown in a composable view. (I'll make a new one and use the commented lyrics button on the player)

Then treat each LyricLine as a button in the view, with 3 states (past, present, future) that will be decided by comparing the item's time field and the MediaControllerVM's current time; and if a button is clicked, then MediaControllerVM should go to that time.

If the lyrics were unsynced then the last step would not be necessary.

I think that covers it, tell me if I'm missing something.
I have already made a fork and implemented a quick POC to test it out, but it lacks proper lyrics sync. https://github.com/AntonioSanFer/android/tree/feature/lyrics

[joelkanyi]

Hey @AntonioSanFer, thanks again for the POC fork. I picked it up and finished the integration on top of #106 in #117. Your original commit is preserved with your authorship, and a follow-up commit adds the bits needed to make it work end to end on current main: lyrics icon in AnimatedPlayerSheet (your NowPlaying.kt change wasn't reaching the active screen post-#106), a couple of bug fixes around position math and the LRC time field (server returns fractional ms), status bar padding on the header, and dropping the 300ms look-ahead so lines land on their actual timestamps.

Tested on a Pixel 7 Pro across several synced tracks, screenshots in the PR. Would love your review when you have a moment.

[AntonioSanFer]

Thanks for the follow up commit @joelkanyi, everything looks good to me. I just signed the CLA.