Repository navigation
Conversation
Hokila
force-pushed
the
fix/fixit-applier-subtree-offsets
branch
from
November 3, 2026 02:47
feef316 to
7187cd5
Compare
Contributor
Author
|
I self reviewed this PR and did some fix, @rintaro Could you take a look when you have a moment? |
When applying diagnostics or edits to a subtree, edit ranges use absolute offsets from the root syntax tree while `tree.description` starts at offset zero. Normalize edit offsets relative to `tree.position.utf8Offset`, reuse `replacementBytes`, and drop edits that fall outside the subtree range. Update `FixItApplier` doc comments and add subtree tests in `FixItApplierTests.swift`. Resolves swiftlang#2749 rdar://132355564
Hokila
force-pushed
the
fix/fixit-applier-subtree-offsets
branch
from
November 13, 2026 07:57
7187cd5 to
078e2a4
Compare
Contributor
Author
|
Rebased on main and trimmed the changes down to keep this PR simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2749
rdar://132355564
Applying diagnostics or edits to a subtree crashes in
FixItApplierbecause edit ranges use root-file offsets whiletree.descriptionstarts at offset zero.FixItApplier.apply(edits:to:allowDuplicateInsertions:)now shifts edit offsets relative totree.position.utf8Offsetand drops individual edits outsidetree. Also updates the doc comments and adds subtree tests inFixItApplierTests.swift.