Repository navigation
Conversation
Companion to swiftlang/swift-syntax#3498, which adds `SendExprSyntax` for the `send` call expression (experimental feature `SendCalls`, swiftlang/swift#93958). Without a `.sendExpr` case the exhaustive `switch expr.as(ExprSyntaxEnum.self)` statements fail to compile against that swift-syntax branch ("switch must be exhaustive"), which breaks toolchain CI that pairs the two PRs. `send` is an effect specifier like `await`/`unsafe`, so treat it the same way: it does not bind tighter than effects, and it is simple iff its sub-expression is simple. Only compiles against a swift-syntax that has `SendExpr` (the swiftlang/swift-syntax#3498 branch); merge after that PR lands and the swift-syntax pin is bumped.
Contributor
Author
|
swiftlang/swift-syntax#3498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to swiftlang/swift-syntax#3498, which adds
SendExprSyntaxfor thesendcall expression (experimental featureSendCalls, see also swiftlang/swift#93958).Without a
.sendExprcase, the exhaustiveswitch expr.as(ExprSyntaxEnum.self)statements fail to compile against that swift-syntax branch (switch must be exhaustive), which breaks toolchain CI that pairs the two PRs:sendis an effect specifier likeawait/unsafe, so treat it the same way:hasTighterBindingThanEffectisSimpleExpressionDraft: only compiles against a swift-syntax that has
SendExpr(the swiftlang/swift-syntax#3498 branch); merge after that PR lands and the swift-syntax pin here is bumped.