Not All Model Classnames Properly Capitalized When ModelNamePrefix Present

[DarkWingDuckWing]

Description

When specifying a model name prefix in a custom codegen class, some of the generated classes do not have proper capitalization of the original class name. For instance a model name of "account" and a model name prefix of "generated" will produce a class named "Generatedaccount" in file "Generatedaccount.java" when they should be named "GeneratedAccount" and "GeneratedAccount.java", respectively.

Swagger-codegen version

Using 2.2.1

Custom Swagger Codegen Class

import io.swagger.codegen.languages.JavaClientCodegen;

/**
 * Custom Java codegen class
 */
public class JavaUapiCodegen extends JavaClientCodegen {

  public JavaUapiCodegen() {
    super();
    setModelNamePrefix("generated");
  }

}

Suggest a Fix

In class DefaultCodegen.java:

    public String toModelName(final String name) {
        return initialCaps(modelNamePrefix)
            + initialCaps(name) + modelNameSuffix;
    }

[wing328]

@dankling thanks for reporting the issue. May I know if you've time to contribute a fix?

[DarkWingDuckWing]

I can contribute the pull request. I have already run the petstore template for Java, but it looks like this code change affects all languages, do I have to run all petstore templates?

[wing328]

@dankling please just update the Java Petstore sample for the time being and we'll review the change (PR).

[wing328]

@dankling it should be fixed by #4621

Please pull the latest master to give it a try.

[DarkWingDuckWing]

I'm ready to move forward with this, sorry for the delay. Could you please re-open this, @wing328?

[wing328]

@dankling please contact me via the email address in my Github profile as I think I also have another solution for it.