Skip to content

fix: ignore nested outDir files outside generated - #17150

Merged
Rich-Harris merged 1 commit into
version-3from
triage/kit-17148-ignore-outdir-descendants
Sep 18, 2026
Merged

Rich-Harris merged 1 commit into
version-3from
triage/kit-17148-ignore-outdir-descendants

Conversation

@svelte-triage-bot

Copy link
Copy Markdown
Contributor

Description

Fixes #17148.

SvelteKit's Vite watcher ignored only direct children of kit.outDir outside generated. Nested tool output such as .svelte-kit/.svelte-check/tsconfig.json therefore remained watched on macOS/fsevents and could trigger Vite's tsconfig full reload.

This adds a descendant glob alongside the existing direct-child glob so that:

  • nested files under non-generated children are ignored
  • outDir/generated and all of its descendants remain watched
  • existing directory-level ignore behavior is preserved

The regression test resolves the actual SvelteKit/Vite configuration and checks the patterns using Vite's filter implementation, including POSIX-normalized paths for cross-platform coverage.

Testing

  • pnpm -F test-options test:vitest
  • pnpm -F @sveltejs/kit test:unit
  • pnpm lint
  • pnpm check
  • pnpm format

pnpm -F test-options test:dev was also attempted; its Vitest phase passed, but browser tests could not launch because Chrome is not installed in the sandbox.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from b0923e6:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b0923e61076dc7f0342004ac6e1203b555488299

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17150

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b0923e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Rich-Harris marked this pull request as ready for review September 18, 2026 17:52
@Rich-Harris
Rich-Harris merged commit 65f93c8 into sveltejs:version-3 Sep 18, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

svelte-check --tsgo writing .svelte-kit/.svelte-check/tsconfig.json triggers a Vite full reload that 500s any SSR render in flight

1 participant