fix(kit): ensure instrumentation file is posixified on Windows - #14993
elliott-with-the-longest-name-on-github merged 3 commits into
Conversation
🦋 Changeset detectedLatest commit: d40f12f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Not sure why only one of the CI runs timed out, but I think it's safe to retry? |
|
Thanks! I'm curious why this wasn't caught by our Windows tests. Do we need to adjust them or add something? |
|
I'm really not sure... I think it should be running on Windows ( |
08a153b
into
sveltejs:main
…ejs#14993) * fix: ensure correct instrumentation file name on Windows * chore: add changeset file * Apply suggestion from @teemingc --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
This PR fixes a bug on Windows where SvelteKit incorrectly generates the wrong import path for the
instrumentation.server.tsfile. This practically broke the OpenTelemetry integration on Windows because theinstrumentation.server.tsnever gets called in both dev and preview.The fix was pretty simple:
posixifytherelative_instrumentationpath. I was unsure whether to usenode:path/posixor the existingposixifyutility, so I chose the latter to err on the side of existing conventions. Let me know if the former is preferred.Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits