feat: implements .jsonc support to adapter-cloudflare-workers - #13467
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d758e05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
duducpp
changed the title
Member
|
This would need to be in |
removes jsonc-parser dependency
Contributor
Author
I also tried updating it in |
added 11 commits
February 20, 2025 18:28
teemingc
approved these changes
Feb 21, 2025
teemingc
left a comment
teemingc
left a comment
Member
There was a problem hiding this comment.
Thank you! I've updated the docs as well (and fixed some links). It seems like Cloudflare is also pushing for wrangler.jsonc files over wrangler.toml files in their docs
Merged
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…js#13467) * feat: implements jsonc-parse * feat: updates adapter-cloudflare-workers documentation * feat: using vite approach to get wrangler config removes jsonc-parser dependency * update the docs * remove toml dep * add adapter option description for config * allow wrangler to find the config file * add changeset * json and jsonc requires wrangler 3.91.0 * standardise troubleshooting sections * fix lock file * update links * fix pnpm lock --------- Co-authored-by: Chew Tee Ming <chew.tee.ming@nindatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #13465
This PR implementes the same jsonc-parser used in cloudflare wrangler
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits