This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Try to create entity from classes with class prefixes - #65
Closed
florianbuerger wants to merge 3 commits into
Closed
Try to create entity from classes with class prefixes#65florianbuerger wants to merge 3 commits into
florianbuerger wants to merge 3 commits into
Conversation
The entity description fails if the class name doesn't match the entity name (a common problem with class prefixes) This change tries to create the entity from the classname stripping the first two or three letter.
Owner
|
@florianbuerger thanks for the PR. Honestly, I'm not sure this is the right way of doing things. |
Author
|
Yeah, after a little bit of thought I think you are right. There are to many places where something can go wrong, I'll just rename my entity to match the class names or override Please don't merge the pull request 😄 |
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entity description fails if the class name doesn't match the entity
name (a common problem with class prefixes)
This change tries to create the entity from the classname stripping the
first two or three letter.
If this doesn't help, an exception is thrown.