fix: [LM-4143] Render AppBar bottom border instead of full box border - #631
Merged
Conversation
AppBar inherited Paper's elevation0 full box border, making the Shipper
TMS nav headers (Pricing Insights, Dashboard) inconsistent with the rest
of the bar. Override .MuiAppBar-root.MuiPaper-elevation0 so the compound
selector deterministically drops the box border and keeps a single
bottom border; elevation={1}+ consumers keep the elevated look.
- DrawerActions relied on the inherited box for its top-divider width, so
it declares its own borderTop to avoid losing the divider on sticky.
- Changes the AppBar default for every @superdispatch/ui consumer;
cross-repo verification tracked in LM-4182.
Contributor
Size Limit ReportTotal Size: 596 kB Size Change: +26 B (+0%)
ℹ️ View Unchanged
|
Contributor
|
Preview deployed: https://a6c7ab33.web-ui-legacy.pages.dev |
Contributor
|
🚨 Snapshot command failed Snapshots are updated automatically in following commit f0b7a1c Please review before merging. |
SiriusCrain
approved these changes
Aug 5, 2026
Contributor
|
Please ensure that after update changes will be properly tested in all places where it used. |
lapapooh
reviewed
Aug 7, 2026
lapapooh
approved these changes
Aug 7, 2026
Contributor
|
🚨 Snapshot command failed Snapshots are updated automatically in following commit d04ff34 Please review before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Removes the full box border AppBar inherited from Paper
elevation0(via the.MuiAppBar-root.MuiPaper-elevation0compound selector), leaving a single bottom border. This changes the AppBar default for every@superdispatch/uiconsumer, not just Shipper TMS — cross-repo verification is tracked in LM-4182.DrawerActionsrelied on the inherited box for its top divider, so it now declares its own.Implemented:
AppBarOverrides.ts: bottom-border default;elevation={1}+opts out.DrawerActions.tsx: explicit top divider to avoid a sticky-state regression.Checklist:
JIRA card:
https://superdispatch.atlassian.net/browse/LM-4143
Should know about:
Visible UI change — before/after screenshots need adding (AppBar loses its box outline, keeps a bottom rule). Shared surface: affects all
@superdispatch/uiAppBar consumers org-wide.