Skip to content

fix: delete all buckets with storage rm #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweatybridge merged 1 commit into from
Jul 14, 2025
Merged

fix: delete all buckets with storage rm #3853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ cp -r ss:///bucket/docs .
Example: `rm -r ss:///bucket/docs
rm ss:///bucket/docs/example.md ss:///bucket/readme.md
`,
Args: cobra.MinimumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
return rm.Run(cmd.Context(), args, recursive, afero.NewOsFs())
},
Expand Down
15 changes: 14 additions & 1 deletion internal/storage/rm/rm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,22 @@ func Run(ctx context.Context, paths []string, recursive bool, fsys afero.Fs) err
if err != nil {
return err
}
if len(groups) == 0 {
if !recursive {
return errors.New(errMissingFlag)
}
buckets, err := api.ListBuckets(ctx)
if err != nil {
return err
}
for _, b := range buckets {
groups[b.Name] = []string{""}
}
}
console := utils.NewConsole()
for bucket, prefixes := range groups {
confirm := fmt.Sprintf("Confirm deleting files in bucket %v?", utils.Bold(bucket))
if shouldDelete, err := utils.NewConsole().PromptYesNo(ctx, confirm, false); err != nil {
if shouldDelete, err := console.PromptYesNo(ctx, confirm, false); err != nil {
return err
} else if !shouldDelete {
continue
Expand Down