Skip to content

fix: include scopes from deno.json #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweatybridge merged 1 commit into from
Jun 26, 2025
Merged

fix: include scopes from deno.json #3773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions internal/utils/deno.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,7 @@ func BindHostModules(cwd, relEntrypointPath, relImportMapPath string, fsys afero
}
// Resolving all Import Graph
addModule := func(unixPath string, w io.Writer) error {
hostPath := filepath.FromSlash(unixPath)
if path.IsAbs(unixPath) {
hostPath = filepath.VolumeName(cwd) + hostPath
} else {
hostPath = filepath.Join(cwd, hostPath)
}
hostPath := toHostPath(cwd, unixPath)
f, err := fsys.Open(hostPath)
if err != nil {
return errors.Errorf("failed to read file: %w", err)
Expand All @@ -247,10 +242,29 @@ func BindHostModules(cwd, relEntrypointPath, relImportMapPath string, fsys afero
if err := importMap.WalkImportPaths(unixPath, addModule); err != nil {
return nil, err
}
// TODO: support scopes
// Also mount local directories declared in scopes
for _, scope := range importMap.Scopes {
for _, unixPath := range scope {
hostPath := toHostPath(cwd, unixPath)
// Ref: https://docs.deno.com/runtime/fundamentals/modules/#overriding-https-imports
if _, err := fsys.Stat(hostPath); err != nil {
return nil, errors.Errorf("failed to resolve scope: %w", err)
}
dockerPath := ToDockerPath(hostPath)
modules = append(modules, hostPath+":"+dockerPath+":ro")
}
}
return modules, nil
}

func toHostPath(cwd, unixPath string) string {
hostPath := filepath.FromSlash(unixPath)
if path.IsAbs(unixPath) {
return filepath.VolumeName(cwd) + hostPath
}
return filepath.Join(cwd, hostPath)
}

func ToDockerPath(absHostPath string) string {
prefix := filepath.VolumeName(absHostPath)
dockerPath := filepath.ToSlash(absHostPath)
Expand Down