Skip to content

fix: adjust api key handling for logflare, studio, and vecor#3653

Merged
sweatybridge merged 2 commits into
developfrom
fix/api-key-logflare-vector-studio
Jun 5, 2025
Merged

fix: adjust api key handling for logflare, studio, and vecor#3653
sweatybridge merged 2 commits into
developfrom
fix/api-key-logflare-vector-studio

Conversation

@Ziinc

@Ziinc Ziinc commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the API key handling for logflare, vector, and studio

  • all services uses a private access token, since this is not meant for production purposes we don't bother generating another key to reduce complexity.
  • vector config now passes logflare api key through headers instead of url, to avoid logging it

This PR requires a subsequent version bump after supabase/supabase#36169 is merged

  • verify locally that all works

@Ziinc Ziinc requested a review from a team as a code owner June 4, 2025 11:53
@coveralls

coveralls commented Jun 4, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15445645132

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.84%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 15445566154: -0.03%
Covered Lines: 5977
Relevant Lines: 10899

💛 - Coveralls

@sweatybridge

Copy link
Copy Markdown
Contributor

working as expected after updating studio

Screenshot 2025-06-05 at 4 26 15 PM

there are errors affecting edge function and cron logs. but those can be resolved separately

@sweatybridge sweatybridge merged commit 865f304 into develop Jun 5, 2025
12 checks passed
@sweatybridge sweatybridge deleted the fix/api-key-logflare-vector-studio branch June 5, 2025 08:33
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants