Skip to content

fix: always use the latest pkg#3645

Merged
sweatybridge merged 4 commits into
developfrom
reuse-spec
Jun 3, 2025
Merged

fix: always use the latest pkg#3645
sweatybridge merged 4 commits into
developfrom
reuse-spec

Conversation

@sweatybridge

@sweatybridge sweatybridge commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

openapi spec

What is the new behavior?

Now that our api spec is relatively stable, we can consolidate generated client libs to be based on the live endpoint.

  • Replaces beta.yaml with overlay.yaml

Additional context

The plugin we use doesn't support user defined $ref so there are a lot of duplicated component schemas.

@sweatybridge sweatybridge requested a review from a team as a code owner June 2, 2025 09:13

@jgoux jgoux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
There is just an issue with uncommit files after the codegen which is failing the CI. 👍

@sweatybridge sweatybridge merged commit 8c396cf into develop Jun 3, 2025
9 checks passed
@sweatybridge sweatybridge deleted the reuse-spec branch June 3, 2025 02:46
@coveralls

coveralls commented Jun 3, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15407158199

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 55.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 15388080599: -0.03%
Covered Lines: 5959
Relevant Lines: 10790

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants