Skip to content

fix: use new api types#3621

Merged
sweatybridge merged 2 commits into
developfrom
bump-api
May 27, 2025
Merged

fix: use new api types#3621
sweatybridge merged 2 commits into
developfrom
bump-api

Conversation

@sweatybridge

@sweatybridge sweatybridge commented May 27, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the new behavior?

  • parses string to uuid before calling api
  • workaround for inline enums in query param
  • many workarounds for using anonymous structs

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge marked this pull request as ready for review May 27, 2025 11:53
@sweatybridge sweatybridge requested a review from a team as a code owner May 27, 2025 11:53
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15274779822

Details

  • 64 of 129 (49.61%) changed or added relevant lines in 24 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 60.092%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/branches.go 0 1 0.0%
internal/sso/internal/render/render.go 10 11 90.91%
internal/sso/internal/saml/files.go 6 7 85.71%
internal/bootstrap/bootstrap.go 0 2 0.0%
internal/projects/create/create.go 2 4 50.0%
internal/sso/get/get.go 4 6 66.67%
internal/sso/remove/remove.go 4 6 66.67%
internal/ssl_enforcement/update/update.go 0 3 0.0%
pkg/function/batch.go 5 8 62.5%
cmd/projects.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
internal/sso/get/get.go 1 50.0%
internal/sso/remove/remove.go 1 57.14%
internal/sso/update/update.go 1 54.67%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 15267953689: -0.1%
Covered Lines: 9015
Relevant Lines: 15002

💛 - Coveralls

@hf hf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be OK.

@sweatybridge sweatybridge merged commit 2ac3b73 into develop May 27, 2025
@sweatybridge sweatybridge deleted the bump-api branch May 27, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants