Skip to content

fix: do not restart auth sequence on reset#3552

Merged
sweatybridge merged 1 commit into
developfrom
no-restart
May 10, 2025
Merged

fix: do not restart auth sequence on reset#3552
sweatybridge merged 1 commit into
developfrom
no-restart

Conversation

@sweatybridge

@sweatybridge sweatybridge commented May 10, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix #3551

What is the current behavior?

identity restart requires privilege to drop sequence, which is no longer granted to the postgres role.

What is the new behavior?

Most of the time, there's no need to reset any sequences in managed schemas.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner May 10, 2025 16:21
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14947091449

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 60.195%

Files with Coverage Reduction New Missed Lines %
internal/utils/container_output.go 2 60.96%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 14946719914: -0.01%
Covered Lines: 9013
Relevant Lines: 14973

💛 - Coveralls

@sweatybridge sweatybridge merged commit 98f6278 into develop May 10, 2025
@sweatybridge sweatybridge deleted the no-restart branch May 10, 2025 16:30
@github-actions github-actions Bot mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR: Resetting databases failing on all new databases & feature branches (ERROR 42501)

2 participants