Skip to content

fix(config): sanitize dotenv errors avoiding data leaking#3529

Merged
avallete merged 5 commits into
developfrom
fix/sanitize-dotenv-loading-error
May 6, 2025
Merged

fix(config): sanitize dotenv errors avoiding data leaking#3529
avallete merged 5 commits into
developfrom
fix/sanitize-dotenv-loading-error

Conversation

@avallete

@avallete avallete commented May 6, 2025

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Print full error when in debug mode
  • Otherwise, parse native godotenv error to sanitize values that might be leaking from the dotenv file.

@avallete avallete requested a review from a team as a code owner May 6, 2025 07:49
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go
@avallete avallete requested a review from sweatybridge May 6, 2025 08:58

@sweatybridge sweatybridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nitpicks

Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config_test.go Outdated
Comment thread pkg/config/config.go Outdated
Co-authored-by: Han Qiao <sweatybridge@gmail.com>
@avallete avallete requested a review from sweatybridge May 6, 2025 10:03
@avallete avallete merged commit 668c9bc into develop May 6, 2025
@avallete avallete deleted the fix/sanitize-dotenv-loading-error branch May 6, 2025 10:23
@github-actions github-actions Bot mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants