chore: add some utils tests #3514
Conversation
Something is not right with coverage reporting
There was a problem hiding this comment.
This is mostly covered by internal/utils/api_test.go but was reported as 0% due to a bug in coverage reporting introduced by go 1.24 upgrade. I've fixed the coverage reporting issue so could you rebase and verify if these tests are improving coverage?
Historically a large part of this file was moved from internal/utils/api.go and it wasn't worth the effort to rewrite or refractor the tests that already covered the code paths.
There was a problem hiding this comment.
This test randomly fails due to a race condition in the underlying implementation. The code path is only affecting pgadmin schema diff tool which we plan to deprecate.
I'd suggest removing this test since there's no need to further maintain this code.
Pull Request Test Coverage Report for Build 14834415000Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
What kind of change does this PR introduce?