Skip to content

chore: explicit permission in actions#3411

Merged
sweatybridge merged 4 commits into
developfrom
chore-review-actions
May 23, 2025
Merged

chore: explicit permission in actions#3411
sweatybridge merged 4 commits into
developfrom
chore-review-actions

Conversation

@doublethink

@doublethink doublethink commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Small fix to add explicit permissions to actions

@doublethink doublethink requested a review from a team as a code owner April 10, 2025 04:08
@sweatybridge

Copy link
Copy Markdown
Contributor

@doublethink are you still working on the test failures?

@doublethink doublethink force-pushed the chore-review-actions branch from 13694e1 to 6e6d3bd Compare May 23, 2025 05:15
@doublethink

Copy link
Copy Markdown
Contributor Author

@sweatybridge Had a look into this an the error message suggests there is a change to the package that is throwing this error not to permission?
Checking the Install Actions history, it looks like a new issue with this Action unrelated to the permission changes

@coveralls

coveralls commented May 23, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15212977906

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 69 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.201%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
internal/start/start.go 64 65.06%
Totals Coverage Status
Change from base Build 15202513015: -0.02%
Covered Lines: 9026
Relevant Lines: 14993

💛 - Coveralls

@sweatybridge

Copy link
Copy Markdown
Contributor

hmm you are right. it looks like a duplicate of #3489 (comment)

@sweatybridge sweatybridge changed the title ci: explicit permission in actions chore: explicit permission in actions May 23, 2025
@sweatybridge sweatybridge merged commit 09d4870 into develop May 23, 2025
@sweatybridge sweatybridge deleted the chore-review-actions branch May 23, 2025 14:47
@github-actions github-actions Bot mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants