Skip to content

feat(cli): setup postgres17 for local development#3387

Merged
sweatybridge merged 8 commits into
developfrom
avallete/devwf-385-support-major-version-17-in-cli
Apr 8, 2025
Merged

feat(cli): setup postgres17 for local development#3387
sweatybridge merged 8 commits into
developfrom
avallete/devwf-385-support-major-version-17-in-cli

Conversation

@avallete

@avallete avallete commented Apr 3, 2025

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Introduce pg17 as a possible image for the local dev experience.

Comment thread pkg/config/config.go Outdated
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14243325465

Details

  • 3 of 11 (27.27%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 51.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 2 5 40.0%
internal/utils/config.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
Totals Coverage Status
Change from base Build 14223436790: -0.02%
Covered Lines: 6968
Relevant Lines: 13643

💛 - Coveralls

@avallete avallete marked this pull request as ready for review April 3, 2025 12:58
@avallete avallete requested a review from a team as a code owner April 3, 2025 12:58
Comment thread internal/utils/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/constants.go Outdated
Comment thread pkg/config/templates/Dockerfile Outdated
Comment thread pkg/config/constants.go
const (
pg13 = "supabase/postgres:13.3.0"
pg14 = "supabase/postgres:14.1.0.89"
pg15 = "supabase/postgres:15.8.1.069"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

To rename Pg15 and Pg17 under the single Pg I still needed a way to address the specific pg15 version in some case. I went like for pg13 and pg14 and pointed to the latest available version at the time. Not sure if that's the way to go though.

@sweatybridge sweatybridge merged commit 2d3bd36 into develop Apr 8, 2025
@sweatybridge sweatybridge deleted the avallete/devwf-385-support-major-version-17-in-cli branch April 8, 2025 09:18
@github-actions github-actions Bot mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants