Fix: Don't overwrite api.external_url from config.toml#3119
Merged
Conversation
Pull Request Test Coverage Report for Build 13209620764Details
💛 - Coveralls |
sweatybridge
approved these changes
Feb 8, 2025
sweatybridge
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This fixes a bug that prevents users from setting a config value containing the external URL that the Supabase API will be deployed at.
What is the current behavior?
As stated in #3118, although the
api.external_urlconfig field exists, its value is always overwritten in pkg/config/config.go. This prevents the user from setting the external URL that is used for things like Supabase Auth generating links.What is the new behavior?
Now, if there is a value supplied for
api.external_url, it will be used as the API's external URL. If there is not a value supplied forapi.external_url, it will still be set to a value derived from the hardcoded hostname, "127.0.0.1".