Skip to content

Fix: Don't overwrite api.external_url from config.toml#3119

Merged
sweatybridge merged 1 commit into
supabase:developfrom
townchest:develop
Feb 8, 2025
Merged

Fix: Don't overwrite api.external_url from config.toml#3119
sweatybridge merged 1 commit into
supabase:developfrom
townchest:develop

Conversation

@toBeOfUse

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

This fixes a bug that prevents users from setting a config value containing the external URL that the Supabase API will be deployed at.

What is the current behavior?

As stated in #3118, although the api.external_url config field exists, its value is always overwritten in pkg/config/config.go. This prevents the user from setting the external URL that is used for things like Supabase Auth generating links.

What is the new behavior?

Now, if there is a value supplied for api.external_url, it will be used as the API's external URL. If there is not a value supplied for api.external_url, it will still be set to a value derived from the hardcoded hostname, "127.0.0.1".

@toBeOfUse toBeOfUse requested a review from a team as a code owner February 7, 2025 23:15
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13209620764

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.329%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13195330422: -0.02%
Covered Lines: 7679
Relevant Lines: 13165

💛 - Coveralls

@sweatybridge sweatybridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@sweatybridge sweatybridge merged commit 097311c into supabase:develop Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants