Skip to content

fix: improve function config parse error message#3101

Merged
avallete merged 5 commits into
developfrom
andrewvalleteau/devwf-339-functionsslugname-is-not-obvious
Feb 5, 2025
Merged

fix: improve function config parse error message#3101
avallete merged 5 commits into
developfrom
andrewvalleteau/devwf-339-functionsslugname-is-not-obvious

Conversation

@avallete

@avallete avallete commented Feb 4, 2025

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Improve the functions parse config error to give more actionable error message for functions in common case of Unknown field or functions[0] ... expected a map error.

@avallete avallete requested a review from a team as a code owner February 4, 2025 05:18
@linear

linear Bot commented Feb 4, 2025

Copy link
Copy Markdown

@coveralls

coveralls commented Feb 4, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13131755740

Details

  • 29 of 30 (96.67%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 58.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/decode_hooks.go 28 29 96.55%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13110034559: 0.06%
Covered Lines: 7628
Relevant Lines: 13104

💛 - Coveralls

Comment thread pkg/config/config.go Outdated

@sweatybridge sweatybridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Comment thread pkg/config/decode_hooks.go Outdated
Comment thread pkg/config/decode_hooks.go Outdated
@avallete avallete requested a review from sweatybridge February 4, 2025 09:17
@avallete avallete merged commit a151606 into develop Feb 5, 2025
@avallete avallete deleted the andrewvalleteau/devwf-339-functionsslugname-is-not-obvious branch February 5, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants