Skip to content

fix: print notices from migration statements#3091

Merged
sweatybridge merged 2 commits into
developfrom
m-debug
Jan 31, 2025
Merged

fix: print notices from migration statements#3091
sweatybridge merged 2 commits into
developfrom
m-debug

Conversation

@sweatybridge

@sweatybridge sweatybridge commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Improve migration debugging experience by logging notice messages and error details.

Applying migration 1_schema.sql...
ERROR: syntax error at or near "exist" (SQLSTATE 42601)
At statement 0:                                        
create table if not exist my_table (name text)         
                    ^                           

Additional context

Add any other context or screenshots.

@coveralls

coveralls commented Jan 31, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13077522830

Details

  • 13 of 20 (65.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.151%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/pgxv5/connect.go 1 3 33.33%
pkg/migration/file.go 12 17 70.59%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13067810194: -0.02%
Covered Lines: 7609
Relevant Lines: 13085

💛 - Coveralls

@sweatybridge sweatybridge force-pushed the m-debug branch 2 times, most recently from a5d71d8 to 84d4210 Compare January 31, 2025 10:29
Comment thread pkg/migration/file.go
@sweatybridge sweatybridge merged commit 2aef3bf into develop Jan 31, 2025
@sweatybridge sweatybridge deleted the m-debug branch January 31, 2025 17:22
@github-actions github-actions Bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants