feat: support ledger solana offchain message signing#2093
Merged
Conversation
2 tasks
Contributor
Author
|
Pinging the people that seem to be maintaining Solana according to latest |
kimsoo527
approved these changes
Aug 4, 2025
kimsoo527
approved these changes
Aug 4, 2025
kimsoo527
approved these changes
Aug 4, 2025
kimsoo527
approved these changes
Aug 4, 2025
kimsoo527
approved these changes
Aug 4, 2025
kimsoo527
approved these changes
Aug 4, 2025
mindrunner
approved these changes
Aug 4, 2025
hf
approved these changes
Aug 5, 2025
hf
left a comment
hf
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Could you please see if the suggested code works and go with it, aids readability?
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
Contributor
Author
I applied the suggestion, and made sure the tests still pass. |
Contributor
Author
|
@hf I've addressed linter's gosec errors |
Pull Request Test Coverage Report for Build 16751519116Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cemalkilic
pushed a commit
that referenced
this pull request
Aug 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.178.0](v2.177.0...v2.178.0) (2025-08-05) ### Features * add sign in with ethereum ([#2069](#2069)) ([079b242](079b242)) * add support for managing SSO providers by resource_id ([#2081](#2081)) ([5ca4489](5ca4489)) * log all audit events separately to prevent missing events ([#2086](#2086)) ([3b666f5](3b666f5)) * skip nonce check for Facebook Limited Login auth ([#2082](#2082)) ([f1b15ff](f1b15ff)) * support ledger solana offchain message signing ([#2093](#2093)) ([4c94443](4c94443)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fadymak
pushed a commit
that referenced
this pull request
Sep 30, 2025
Supports Solana off-chain messages signed with Ledger, as described in this issue: #2092 --------- Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
fadymak
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.178.0](v2.177.0...v2.178.0) (2025-08-05) ### Features * add sign in with ethereum ([#2069](#2069)) ([079b242](079b242)) * add support for managing SSO providers by resource_id ([#2081](#2081)) ([5ca4489](5ca4489)) * log all audit events separately to prevent missing events ([#2086](#2086)) ([3b666f5](3b666f5)) * skip nonce check for Facebook Limited Login auth ([#2082](#2082)) ([f1b15ff](f1b15ff)) * support ledger solana offchain message signing ([#2093](#2093)) ([4c94443](4c94443)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports Solana off-chain messages signed with Ledger, as described in this issue: #2092