Skip to content

fix: redirects must not be to ip addresses #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hf merged 1 commit into from
Apr 14, 2025
Merged

fix: redirects must not be to ip addresses #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions internal/utilities/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"net"
"net/http"
"net/url"
"regexp"
"strings"

"github.com/supabase/auth/internal/conf"
Expand Down Expand Up @@ -79,6 +80,8 @@ func GetReferrer(r *http.Request, config *conf.GlobalConfiguration) string {
return config.SiteURL
}

var decimalIPAddressPattern = regexp.MustCompile("^[0-9]+$")

func IsRedirectURLValid(config *conf.GlobalConfiguration, redirectURL string) bool {
if redirectURL == "" {
return false
Expand All @@ -92,9 +95,17 @@ func IsRedirectURLValid(config *conf.GlobalConfiguration, redirectURL string) bo
return true
}

// Clean up the referrer URL to avoid pattern matching an invalid URL
refurl.Fragment = ""
refurl.RawQuery = ""
if rerr != nil {
// redirect URL is for some reason invalid
return false
}

if decimalIPAddressPattern.MatchString(refurl.Hostname()) {
// IP address in decimal form also not allowed in redirects!
return false
} else if ip := net.ParseIP(refurl.Hostname()); ip != nil {
return ip.IsLoopback()
}

// For case when user came from mobile app or other permitted resource - redirect back
for _, pattern := range config.URIAllowListMap {
Expand Down
29 changes: 27 additions & 2 deletions internal/utilities/request_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func TestGetIPAddress(t *tst.T) {
func TestGetReferrer(t *tst.T) {
config := conf.GlobalConfiguration{
SiteURL: "https://example.com",
URIAllowList: []string{"http://localhost:8000/*", "http://*.localhost:8000/*"},
URIAllowList: []string{"http://localhost:8000/*", "http://*.localhost:8000/*", "http://*:12345/*", "http://**:12345/*"},
JWT: conf.JWTConfiguration{
Secret: "testsecret",
},
Expand Down Expand Up @@ -128,10 +128,35 @@ func TestGetReferrer(t *tst.T) {
expected: "http://localhost:8000/path?param=1",
},
{
desc: "invalid redirect url via query smurfing",
desc: "invalid redirect url due to decimal IP address",
redirectURL: "http://123?.localhost:8000/path",
expected: config.SiteURL,
},
{
desc: "invalid redirect url due to IPv4 address",
redirectURL: "http://123.123.123.123?localhost:8000/path",
expected: config.SiteURL,
},
{
desc: "invalid redirect url due to IPv6 address",
redirectURL: "http://[65e7:9410:d8b6:e227:58cd:e55b:8fc0:206d]?localhost:8000/path",
expected: config.SiteURL,
},
{
desc: "invalid redirect url due to bad URL",
redirectURL: "http://65e7:9410:d8b6:e227:58cd:e55b:8fc0:206d?localhost:8000/path",
expected: config.SiteURL,
},
{
desc: "valid loopback IPv4 address",
redirectURL: "http://127.0.0.1:12345/path",
expected: "http://127.0.0.1:12345/path",
},
{
desc: "valid loopback IPv6 address",
redirectURL: "http://[0:0:0:0:0:0:0:1]:12345/path",
expected: "http://[0:0:0:0:0:0:0:1]:12345/path",
},
}

for _, c := range cases {
Expand Down