Skip to content

refactor: turn off pub access of chain in HelperTemplate#630

Merged
sunng87 merged 1 commit into
masterfrom
fix/turn-off-chain-field-of-helper-template
Jan 18, 2024
Merged

refactor: turn off pub access of chain in HelperTemplate#630
sunng87 merged 1 commit into
masterfrom
fix/turn-off-chain-field-of-helper-template

Conversation

@sunng87

@sunng87 sunng87 commented Jan 18, 2024

Copy link
Copy Markdown
Owner

Because chain is not used during rendering process, here I turned off pub access of this field for better compatibility.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 81.651%. remained the same
when pulling c1a4aef on fix/turn-off-chain-field-of-helper-template
into d8d9a78 on master.

@sunng87 sunng87 merged commit 94d9211 into master Jan 18, 2024
@sunng87 sunng87 deleted the fix/turn-off-chain-field-of-helper-template branch January 18, 2024 13:45
Comment thread src/template.rs
pub inverse: Option<Template>,
pub block: bool,
pub chain: bool,
chain: bool,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this a breaking change?

Before: https://docs.rs/handlebars/5.1.0/handlebars/template/struct.HelperTemplate.html
After: https://docs.rs/handlebars/latest/handlebars/template/struct.HelperTemplate.html

Both removes access to a field and makes the struct no longer directly initializable. If the latter is an expected property, this should have #[non_exhaustive] (but that too is a breaking change)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I didn't realized initialization issue with introducing a private field. Will revert this and yank 5.1.1 for new solution.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't just about initialization but also that a release already exists with pub chain

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is introduced in 5.1.0 and not used in any API. The impact should be minimised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants