assert.Len: print value last - #732
Closed
christopinka wants to merge 3 commits into
Closed
christopinka wants to merge 3 commits into
christopinka wants to merge 3 commits into
Conversation
[stretchr#207 (comment)] - Adjust assert.Len() fail message making the object last so that large object output doesn't obscure the length difference.
christopinka
commented
Feb 22, 2019
| ok, l := getLen(object) | ||
| if !ok { | ||
| //TODO: should it be - \"%s\" could not be applied <to> builtin len() or maybe "len() could not be applied to \"%s\" | ||
| return Fail(t, fmt.Sprintf("\"%s\" could not be applied builtin len()", object), msgAndArgs...) |
Author
There was a problem hiding this comment.
Isn't it - the application of the function ƒ to its argument x? len() applied to object? There could be something I'm missing...
There was a problem hiding this comment.
Yes, I think it should say: "Could not apply len() to "%s"".
|
This would be a very welcome change - having difference at the end of message makes it hard to read |
dolmen
requested changes
Jul 31, 2023
dolmen
left a comment
dolmen
left a comment
Collaborator
There was a problem hiding this comment.
Must be rebased on master.
dolmen
added
enhancement: output format
Collaborator
|
Related to #1801 |
Collaborator
|
Has #1646 (truncate long messages) solved the readability issue in another way? At least length is nowadays displayed last, as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#207 (comment) - Adjust assert.Len() fail message making the object last so that large object output doesn't obscure the length difference.