comments for the require package - #1658
Closed
parth-p-shah wants to merge 3 commits into
Closed
parth-p-shah wants to merge 3 commits into
parth-p-shah wants to merge 3 commits into
Conversation
Collaborator
|
Can you base this on @Neokil's work? Ie begin with their branch and add a commit taking the other parts out. You also need to run |
Author
I'm not able to push into his branch. Also go generate ./... is adding the line: |
Collaborator
|
You don't need to push to their branch: git remote add Neokil git@github.com:Neokil/testify.git
git fetch Neokil
git checkout generate-better-comments-for-require-package
# do work
# commit
# push to your fork
# open PRThis keeps the correct attribution on the work. You'll need to have go generate working and CI passing before this can be reviewed. |
Collaborator
|
Thank you for your efforts @parth-p-shah, but the author has responded in #1610 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was asked and done in #1610 , with the review comments addressed.
Changes
Added a "replace" function to the template
require.go.tmpl now replaces the package name accordingly
require.go.tmpl now adds another line to the function-docs explaining the difference to the assert-function
Motivation
In case of test-cases using both require and assert it gets confusing because the function docs for the require package are referencing the assert package and don't really document the actual function.
Related issues
#1610 - Generate better comments for require package