EventuallyWithTf function help is incorrect, misleading callback signature #1833

Documentation shows that the callback function format is func(c *assert.CollectT, "error message %s", "formatted") which is incorrect.

Formatting arguments are only valid for EventuallyWithTf itself, while the callback is just func(c *assert.CollectT).

The issue appears for:

• assert.EventuallyWithTf():

  testify/assert/assertion_format.go

  Line 193 in 429ee0b

  // assert.EventuallyWithTf(t, func(c *assert.CollectT, "error message %s", "formatted") {

• require.EventuallyWithTf():

  testify/require/require.go

  Line 460 in 429ee0b

  // require.EventuallyWithTf(t, func(c *require.CollectT, "error message %s", "formatted") {

• As a method on*Assertion receiver in assert package:

  testify/assert/assertion_forward.go

  Line 375 in 429ee0b

  // a.EventuallyWithTf(func(c *assert.CollectT, "error message %s", "formatted") {

• As a method on*Assertion receiver in require package:

  testify/require/require_forward.go

  Line 376 in 429ee0b

  // a.EventuallyWithTf(func(c *assert.CollectT, "error message %s", "formatted") {