Repository navigation
Eventually functions documentation is misleading as waitFor and tick are swapped in the example #1677
Closed as not planned
Description
Activity
Hi, I'd like to work on this! What file(s) should be edited? This search query shows five files but I'm unsure if they all should be edited especially since some of them have a comment at the top to not edit -->
// Code generated with github.com/stretchr/testify/_codegen; DO NOT EDIT.Only edit files without the DO NOT EDIT header. To change the rest you run
go generate ./....Reacted by ChinoUkaegbuThanks for your efforts, however I now see this was actually fixed in #1588 but that hasn't been released yet.
I do plan to make a v1.10.0 release soon. I have an ordered list of testify tasks for me to do and making the release is currently second on that list.
Reacted by ChinoUkaegbu
Description
Documentation of
EventuallyWithTandEventuallyWithTffunctions (in both require or assert package) is misleading, as the sample code swapswaitForandtickargs in the call.Step To Reproduce
Go to assert.EventuallyWithT docs and look at the example, it shows
1*time.Second, that is supposed to be thetickas 1st argument that should bewaitFor.Same thing for assert.EventuallyWithTf, require.EventuallyWithT and require.EventuallyWithTf.