`NotSame` should fail if args are not pointers

[brackendawson]

Discussed in #1660

^{Originally posted by n4nn31355 October 16, 2024}
It's confusing and error-prone that NotSame checks nothing if any of the values is not a pointer.
Is there a reason for this, or may we consider it a bug that needs an issue?

a := struct{ byte }{}
require.NotSame(t, a, a)   // Doesn't fail
require.NotSame(t, &a, &a) // Fails
```</div>

[brackendawson]

This is a simple bug, the signature of samePointers needs to be changed to:

func samePointers(first, second interface{}) (same bool, ok bool)

[sikehish]

I'd love to take this up. Could you assign this to me?

[sikehish]

I'd love to take this up. Could you assign this to me?

Thank you. Im looking into the issue.

[sikehish]

Hi @brackendawson ,
I've raised a PR #1664 , do let me know if any changes need to be made.

[janisbiz]

Hi! What about slices? As now NotSame will not work with slices due to samePointers checking if variables are pointers which is not the case with slice.

Thus - samePointers should probably support reflect.SliceHeader for slices?