Repository navigation
Conversation
The Responses stream loop returned on a terminal event without closing the AsyncStream, so shutdown logged an aclose error. Close the stream when that loop finishes, including when it raises. Fixes strands-agents#6160
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAIResponsesModel.stream()left the OpenAI Responses stream open when it stopped onresponse.completedorresponse.incomplete, and also when the stream raised. asyncio then loggedaclose(): asynchronous generator is already runningat loop shutdown.The stream is now closed in a
finallyblock once iteration stops.AsyncStream.close()releases the socket. A plain async iterator, which is what the older tests return, is closed withaclose(). The loop body is otherwise unchanged.Fixes #6160
Testing
A fake async iterator records
close()andaclose(). On HEADc8e1351the new tests failed because nothing closed the stream afterresponse.completed,response.incomplete, or a stream error.After the fix,
hatch test tests/strands/models/test_openai_responses.pypassed (230 tests).hatch fmt, ruff, and mypy were clean on the touched files. This did not call the live OpenAI API.