Repository navigation
fix(plugins): reject a plugin tool whose name is already registered - #6139
Open
AnnasMazhar wants to merge 1 commit into
Open
AnnasMazhar wants to merge 1 commit into
AnnasMazhar wants to merge 1 commit into
Conversation
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6099
A second plugin instance silently replaced the first instance's @tool.
_PluginRegistry._register_toolscallsToolRegistry.process_tools, andregister_toolskips its duplicate-name check for hot-reloadable tools (registry.py:250). Every @tool decorated function is hot-reloadable, so the check never fires and the second plugin's tool overwrites the first one. This matches TypeScript, which throwsTool with name 'ping' already registered(tool-registry.ts:35)._PluginRegistrytracks which plugin registered each tool name and rejects a plugin tool whose name is already taken by a different tool; re-registering the same plugin's own tool is still allowed.Tests:
pytest strands-py/tests/strands/plugins- 88 passed.