You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
As discussed in #2191, the current SPISettings handling is incorrect, it should be made constexpr where applicable.
To Reproduce
Attempt to run something using SubGhz.spi_settings during object initialization, e.g. some RadioLib STM32WL Example.
Additional context
The recent changes to SPI library in 392469a introduced couple of issues. One was addressed by #2191, however, there is also a continued issue with constexpr being removed from SPISettings. To fix:
SPISettings constructors should be made constexpr again, which will require removing init_AlwaysInline + init_MightInline and doing initialization in a simple constructor.
Describe the bug
As discussed in #2191, the current SPISettings handling is incorrect, it should be made
constexprwhere applicable.To Reproduce
Attempt to run something using
SubGhz.spi_settingsduring object initialization, e.g. some RadioLib STM32WL Example.Additional context
The recent changes to SPI library in 392469a introduced couple of issues. One was addressed by #2191, however, there is also a continued issue with
constexprbeing removed fromSPISettings. To fix:SPISettingsconstructors should be madeconstexpragain, which will require removinginit_AlwaysInline+init_MightInlineand doing initialization in a simple constructor.