Skip to content

feat(telemetry): log and report lock-acquisition contention at info #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swarit-stepsecurity wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(telemetry): log and report lock-acquisition contention at info #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,14 @@ func Run(exec executor.Executor, log *progress.Logger, cfg *cli.Config) (err err
// Acquire lock
lk, err := lock.Acquire(exec)
if err != nil {
log.Debug("lock acquisition failed: %v", err)
// Another instance already holds the lock. Surface at info level (not
// Debug) so the contention is visible in agent.log, and report the
// failed run right here — don't wait for the deferred handler — so the
// backend records that this invocation contended for the lock while one
// was already in flight. reportFailedOnce is idempotent, so the deferred
// handler that also fires on the error return is a no-op.
log.Progress("Lock acquisition failed (PID %d): %v — another instance is already running, exiting", os.Getpid(), err)
reportFailedOnce(fmt.Sprintf("lock acquisition failed: %v", err))
return fmt.Errorf("acquiring lock: %w", err)
}
log.Debug("lock acquired (pid=%d)", os.Getpid())
Expand Down
Loading