fix(ssr): revert change that causes css animations in nextjs to play twice - #6537
Closed
OS-jacobbell wants to merge 2 commits into
Closed
fix(ssr): revert change that causes css animations in nextjs to play twice#6537OS-jacobbell wants to merge 2 commits into
OS-jacobbell wants to merge 2 commits into
Conversation
Contributor
|
hey! There was definitely a reason for that.... although I obvs didn't add a test for it :/ |
Contributor
|
Perhaps you could use node.isConnected to stop it from being re-added? |
Contributor
Author
|
Like this on line 273? |
Contributor
|
Yh exactly |
Contributor
|
Ah yeah. Won’t work as the nodes are already connected. Lemme have a think |
Contributor
|
@OS-jacobbell - I think this #6540 should be safe? |
Contributor
Author
|
Let's close this PR and merge yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
In 4.35.2 (#6311) there was a regression that causes CSS animations to restart when an SSR page is hydrated in Next.js dev mode using runtime-based SSR.
GitHub Issue Number: N/A
What is the new behavior?
CSS animations only play once.
Documentation
Does this introduce a breaking change?
Testing
Manually tested.
Other information