Feature/wal 449 smart contracts continued - #644
Merged
piyalbasu merged 24 commits intoOct 6, 2022
Merged
Conversation
* add a first pass at Experimental Mode and SC parsing * better var naming * Add translations * use the right SDK when retrieving sourceKeys * use correct SDK for network * rm unused import * rm console Co-authored-by: GitHub Action <action@github.com>
…WAL-449-smart-contracts-continued # Conflicts: # extension/src/popup/components/signTransaction/Operations/index.tsx # extension/src/popup/components/signTransaction/Operations/styles.scss # extension/src/popup/views/SignTransaction/index.tsx
piyalbasu
commented
Oct 6, 2022
Contributor
piyalbasu
commented
Oct 6, 2022
| {...field} | ||
| /> | ||
| )} | ||
| </Field> |
Contributor
Author
There was a problem hiding this comment.
when a user adds a custom network, let them explicitly allow a HTTP network url
piyalbasu
commented
Oct 6, 2022
| const isSubmitDisabled = isMemoRequired || isMalicious; | ||
|
|
||
| if (_networkPassphrase === networkPassphrase) { | ||
| if (_networkPassphrase !== networkPassphrase) { |
Contributor
Author
There was a problem hiding this comment.
accidentally undid this in my last commit 😬
…m:stellar/freighter into feature/WAL-449-smart-contracts-continued
Contributor
piyalbasu
commented
Oct 6, 2022
| import { StellarTomlResolver } from "stellar-sdk"; | ||
|
|
||
| import { sendMessageToBackground } from "./extensionMessaging"; | ||
| import { stellarSdkServer } from "./stellarSdkServer"; |
Contributor
Author
There was a problem hiding this comment.
the bulk of this PR is this type of change: swapping out the standard Stellar SDK server for one that automatically configures allowHttp, which is needed for users running Horizon locally
piyalbasu
commented
Oct 6, 2022
Contributor
piyalbasu
commented
Oct 6, 2022
| const transaction = SDK.TransactionBuilder.fromXDR( | ||
| transactionXdr, | ||
| SDK.Networks[network], | ||
| networkPassphrase || SDK.Networks[network], |
Contributor
Author
There was a problem hiding this comment.
allow a user to use a custom passphrase not associated with a network. Needed when a user generates a random passphrase with Stellar Quickstart
…m:stellar/freighter into feature/WAL-449-smart-contracts-continued
Contributor
Contributor
1 similar comment
Contributor
…m:stellar/freighter into feature/WAL-449-smart-contracts-continued
Contributor
quietbits
approved these changes
Oct 6, 2022
piyalbasu
added a commit
that referenced
this pull request
Oct 11, 2022
* Feature/wal 449 smart contracts continued (#644) * add a first pass at Experimental Mode and SC parsing (#636) * add a first pass at Experimental Mode and SC parsing * better var naming * Add translations * use the right SDK when retrieving sourceKeys * use correct SDK for network * rm unused import * rm console Co-authored-by: GitHub Action <action@github.com> * allow custom networks and passphrase param * allow connection to http servers; allow custom passphrases in freighter-api * Add translations * better naming * missed one spot * add better API for for stellar sdk server * add different method for network details * rollback getNetworkDetails changes for next pr * roll back ver change * Add translations * add simplebar to Network Form Co-authored-by: GitHub Action <action@github.com> * polish styles for Smart Contract screens (#647) * polish styles for Smart Contract screens * Add translations Co-authored-by: GitHub Action <action@github.com> * add requestNetworkDetails and update docs (#646) * add requestNetworkDetails and update docs * Add translations Co-authored-by: GitHub Action <action@github.com> * copy change (#648) * copy change * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to allow Freighter to interact with Horizon instances that are being run locally. To allow that we need to:
allowHttpin Stellar/Soroban SDK, when necessary