remove stellar.expert usage for Custom networks - #616
Merged
piyalbasu merged 3 commits intoAug 29, 2022
Merged
Conversation
Contributor
1 similar comment
Contributor
piyalbasu
commented
Aug 26, 2022
|
|
||
| if (isCustomNetwork(networkDetails)) { | ||
| return <Redirect to={ROUTES.addAsset} />; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
redirect to the manual "Add Asset" flow as the search will not help someone on a Custom network
piyalbasu
deleted the
feature/WAL-434-disable-stellar-expert-for-custom
branch
August 29, 2022 16:22
piyalbasu
added a commit
that referenced
this pull request
Sep 12, 2022
* update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](jsdom/jsdom@16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](algolia/algoliasearch-helper-js@3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
piyalbasu
added a commit
that referenced
this pull request
Oct 12, 2022
* Release 2.5.0 (#603) * update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](jsdom/jsdom@16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](algolia/algoliasearch-helper-js@3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(): bumping release to 2.5.0 (#626) Co-authored-by: GitHub Action <action@github.com> * add changelog (#627) * add a first pass at Experimental Mode and SC parsing (#636) (#637) * add a first pass at Experimental Mode and SC parsing * better var naming * Add translations * use the right SDK when retrieving sourceKeys * use correct SDK for network * rm unused import * rm console Co-authored-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com> * Add translations Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
piyalbasu
added a commit
that referenced
this pull request
Nov 1, 2022
* update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](https://github.com/jsdom/jsdom/compare/16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](https://github.com/medialize/URI.js/compare/v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * load blocked domains into redux (#611) * add call to stellar expert w todos * finish up * cleanup * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * scam asset pt 2: add new preferences flag, show warning overlay when adding trustline to scam asset (#619) * add call to stellar expert w todos * finish up * cleanup * starting * use toml host in asset descriiption * add settings flag * finish styling with some todos * some refactoring, clean up todos * cleanup * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> * add better error messages for Add Network screen (#628) * handle add asset from warning screen (#631) * handle add asset * cleanup * clean up * use new metric name * check for suspicious characteristics when adding new asset w/ warning view (#634) * check for suspicious characteristics when adding new asset * cleanup * Add translations * pr comments * Add translations Co-authored-by: GitHub Action <action@github.com> * add warning icon to scam assets (#635) * check for suspicious characteristics when adding new asset * cleanup * Add translations * first cut * cleanup * one more icon * one more warning * use SimpleBar Co-authored-by: GitHub Action <action@github.com> * show warning view if sending/swapping with scam asset (#639) * first cut w/ hardcoded stuff * finish up * Add translations Co-authored-by: GitHub Action <action@github.com> * update from master (#643) * Release 2.5.0 (#603) * update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](https://github.com/jsdom/jsdom/compare/16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](https://github.com/medialize/URI.js/compare/v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(): bumping release to 2.5.0 (#626) Co-authored-by: GitHub Action <action@github.com> * add changelog (#627) * add a first pass at Experimental Mode and SC parsing (#636) (#637) * add a first pass at Experimental Mode and SC parsing * better var naming * Add translations * use the right SDK when retrieving sourceKeys * use correct SDK for network * rm unused import * rm console Co-authored-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com> * Add translations Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update soroban-client package name * Add translations * use domain when available for isScamAsset calc, change hook to useIsOwnedScamAsset (#652) * use domain when available for isScamAsset calc * use isOwnedScamAsset * use custom error infloblock component (#653) * custom error infloblock * cleanup * cleaning up some UI discrepancies (#654) * cleaning up some UI discrepancies * Add translations Co-authored-by: GitHub Action <action@github.com> * add a check to see if the assets returned exist on our network (#655) * add a check to see if the assets returned exist on our network * check the toml network passphrase to get network * qa fixes (#657) * use the force/var (#658) * fix bottom padding of new asset warning modal (#659) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
piyalbasu
added a commit
that referenced
this pull request
Nov 17, 2022
* update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](https://github.com/jsdom/jsdom/compare/16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](https://github.com/medialize/URI.js/compare/v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * load blocked domains into redux (#611) * add call to stellar expert w todos * finish up * cleanup * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * scam asset pt 2: add new preferences flag, show warning overlay when adding trustline to scam asset (#619) * add call to stellar expert w todos * finish up * cleanup * starting * use toml host in asset descriiption * add settings flag * finish styling with some todos * some refactoring, clean up todos * cleanup * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> * add better error messages for Add Network screen (#628) * handle add asset from warning screen (#631) * handle add asset * cleanup * clean up * use new metric name * check for suspicious characteristics when adding new asset w/ warning view (#634) * check for suspicious characteristics when adding new asset * cleanup * Add translations * pr comments * Add translations Co-authored-by: GitHub Action <action@github.com> * add warning icon to scam assets (#635) * check for suspicious characteristics when adding new asset * cleanup * Add translations * first cut * cleanup * one more icon * one more warning * use SimpleBar Co-authored-by: GitHub Action <action@github.com> * show warning view if sending/swapping with scam asset (#639) * first cut w/ hardcoded stuff * finish up * Add translations Co-authored-by: GitHub Action <action@github.com> * update from master (#643) * Release 2.5.0 (#603) * update version number * WAL-394, WAL-360: dont round on dest asset amounts, show dest asset balances for swaps (#602) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * Demonic Vulnerability Part 1 (#537) * use hidden words; deref var; first pass at multi field input * prevent copy/download; only store mnemonic phrase string in memory * prevent paste and remove from memory * don't record changes if disabled * add explanation comment * Merge master 2.3.0 (#552) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * Release/2.2.0 (#526) * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * add custom select inputs (#502) * add custom asset select inputs * truncate long asset codes * PR cleanup * create a new selectassetrows comp * add helper * clean up ManageAssetRows * one more * use recommended transaction fee by default (#503) * use recommended transaction fee by default * better conditional * no children * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/… (#514) * added await in async function calls (#467) * adding first attempt at beta pipeline (#483) * change workflow names * rm duped id * rm analytics and change naming * don't bother creating a PR * update naming and use a different version for FF * publish chrome to testers and rename FF artifact * upgrade chrome upload to allow publish target * just run chrome upload * try new secret keys * try the whole thing * change file path for chrome upload * change version naming and set publish to true * add `beta` to version for Firefox * update stellar-sdk for Protocol 19 (#466) * add additional tracking for payments and manage assets (#482) * add additional tracking for payments * undo formatting * add manage asset tracking * emitMetric only when submission succeeds * when fetching balances filter out liquidity pool shares (#484) * filter out liquidity pool share balances * cleanup * use asset canonical ID for key in cache (#495) * only show rate if amount input * use canonicalID for cached assets * fix trans details as well * make change for pp dest asset * use recommended tx fee by default (#506) * use recommended transaction fee by default * better conditional * no children * use mode of max fee instead of fee charged mode (#507) * use 10th percentile of max fee instead of fee charged mode * use mode instead of p10 * use recommended fee for `changeTrust` operation (#510) * update version in Settings (#511) * docs(): bumping release to 2.1.2 (#513) Co-authored-by: GitHub Action <action@github.com> * Merge commit 'd226474d72a8ea83915f302e6eace2986c4e3f89' into release/2.2.0 # Conflicts: # extension/src/popup/components/manageAssets/ManageAssetRows/index.tsx Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * merging 2.3.0 into 2.2.0 - swaps, removing network from onboarding screens (#523) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * add swap support pt2 (#520) * first cut, with todos * finish swaps * add comment * edge case * create the TwoAssetCard * dont show warning if successful * remove network from onboarding screens (#522) * add a search asset view (#517) * add a search asset view * ux adjustments * move ResultsHeader outside component * update the collectedTags array (#524) * adding default and loading icons (#525) * adding default and loading icons * PR comments * make sendSettings rows clickable, add pin extension view (#527) * sendsettings * add pin extension screen * cleanup * Update extension/src/popup/views/FullscreenSuccessMessage/index.tsx Co-authored-by: Piyal Basu <pbasu235@gmail.com> * detect chrome, use old image/copy if not * update copy Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/request public key (#528) * add first pass of request public key feature * handle account switching * handle password verification * fix selecting different account * better naming * simplify autoselect logic * fix comment * use map for allAccounts * update freighter-api version * PR comments * update freighter-api ver number * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk * Bugfix/allow null network (#545) * allow null since there is a 3rd possible param * allow `null` as network param * Bugfix/allow muxed federation in sign transaction (#546) * allow null since there is a 3rd possible param * allow `null` as network param * allow muxed and federation accounts in signTransation; standardize checks for muxed/federation Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * docs(): bumping release to 2.2.0 (#547) Co-authored-by: GitHub Action <action@github.com> * add missing release notes (#548) * add missing release notes * Remove jira ticket keys * add bullet pts * fix (#549) * docs(): bumping release to 2.2.1 (#550) Co-authored-by: GitHub Action <action@github.com> * 2.2.1 release notes (#551) Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Just use 12 word phrases for now and cleanup UI (#553) * Feature/ledger (#557) * add connecting with ledger UI (#531) * add swap routes, and make SendAmount changes (#515) * first cut * add swap icon * make SendAmount changes * cleanup * cleanup * finish sendAmount styling * cleanup * use consts * remove important * first cut, import ledgers, got connecting to work * cleanup * UI changes / first cut with todos * finish pt1 * cleanup * cleanup * make type WalletType * add importHardwareWallet to background services w/ background tests (#538) * fix sendAmount header moving (#532) * first cut with todos * hardcoded w/ todos * cleanup * add background tests * cleanup * cleanup * merge Release/2.2.0 (#543) * fix sendAmount header moving (#532) * qa fixes (#533) * show the loader while we're waiting for asset icons to be fetched; add comments (#534) * New styles for mnemonic phrase confirmed screen (#536) * new styles * additional text styling * load assetIcons from swap screen, increase padding in accounst select (#535) * load asseticons from swap screen * increase account slide up padding * cleanup * adjust border radius for Path/Swap asset selects (#539) * adjust border radius for Path/Swap asset selects * better naming * better better naming * use first non-xlm asset as default dest asset for swaps (#540) * use non xlm for default swap dest asset * use StellarSdk Co-authored-by: Piyal Basu <pbasu235@gmail.com> * store hardwareWallet in redux, background methods changes for when hardwareWallet active (#544) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * send transactions with ledger (#554) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * support non default-bip path, store hw data in localstorage, add animation (#555) * add ledger account to account list dropdown * cleanup * finish test" * increase account list height * simplify * almost finished regular send flow, changes to manage asset view * got it all working :D, still need to cleanup * finish * cleanup * cleanup * use await * use const * animate ledger, enforce cant re-import same account * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Feature/localization (#558) * add localization config and translation files * add build cmd for translations in root * Bump jsdom from 16.4.0 to 16.5.0 (#541) Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](https://github.com/jsdom/jsdom/compare/16.4.0...16.5.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * Bump eventsource from 1.0.7 to 1.1.1 (#518) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump async from 2.6.3 to 2.6.4 (#462) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#461) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.21.1 to 0.21.4 (#460) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.2 to 1.19.11 (#459) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.2 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](https://github.com/medialize/URI.js/compare/v1.19.2...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump algoliasearch-helper from 3.2.2 to 3.7.0 (#350) Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.7.0. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.7.0) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump shelljs from 0.8.4 to 0.8.5 (#349) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * fix validation issues; fix typo; rm Add Asset btn (#559) * Feature/wal 264 about links (#560) * rm extra links and translate About view * fix path not found validation * add workflow to release branch (#566) * Bump async from 2.6.3 to 2.6.4 (#564) * Add Action to to auto run translations job on PR/push (#563) * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix on statement * change on param * yarn before build * build freighter-api * try head_ref * moving ledger connect to own move, some refactoring to confirmPassword in background (#572) * first cut * finish * translations * sign external app transactions with hardware wallet (#573) * first cut * finish * translations * sign external app transaction with ledger * use signedTransaction * add check diff * fix spacing * add id * tx fee in xlm (#575) * use toFixed instead of toString (#576) * error message updates (#577) * handle rejected ledger transaction (#578) * handle tx rejected message * translations * return bipPath from confirmPassword (#579) * use toFixed instead of toString (#576) * return the bip path after confirming password * undo * cleanup * Bump terser from 4.8.0 to 4.8.1 (#580) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * display transaction error details (#584) * finish UI, clean up test * Add translations * translations * add ErrorDetails interface Co-authored-by: GitHub Action <action@github.com> * show swaps in account history (#585) * add swaps to history * cleanup * translations * Feature/wal 257 https only (#586) * add logic to check for https * add https check and fix tests * add getTransactionInfo tests and update all jest libs * rm unneeded script * rm unused mock and fix dom nesting * rm unneeded dom elements * WAL-319, WAL-342: dont allow mnemonic re-view, bottom nav hover state (#587) * add bottom nav hover state * if already confirmed mnemonic dont re-view * handle LP shares (#588) * handle lp shares * cleanup * cleanup * add asset balance UI and refactor History to share code (#590) * add asset balance UI and refactor History to share code * Add translations * PR comments; disable LP detail; use canonical asset * fix missing date * update version number Co-authored-by: GitHub Action <action@github.com> * add loader, default self payment to sent (#595) * WAL-402: asset detail send/swap use as default asset (#596) * default send/swap asset to chosen one * native * wait until we asset domain resolves before showing view (#597) * qa fixes (#599) * put LPs last * validate transaction fee * use XLM, not native for LP name * Add translations Co-authored-by: GitHub Action <action@github.com> * categorize create external account ops as Sent (#598) * categorize create external account ops as Sent * Add translations * use the Payment transaction detail * update header title and add translations Co-authored-by: GitHub Action <action@github.com> * display full decimal for destination amount in send flow * show balances for swaps * cleanup Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * WAL-446: lift asset select code to redux (#604) * lift asset select stuff to redux * use isSource * Feature/wal 434 add custom network Pt 1 (#609) * Add a custom network and switch to it * add a custom network and switch to it * fix PR comments and fix failing build * Add translations Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 edit custom network (#612) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * Feature/wal 434 add network settings in settings (#613) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode Co-authored-by: GitHub Action <action@github.com> * fix some incosistencies in styling (#614) * Add a custom network and switch to it * add a custom network and switch to it * add ability to edit network * fix PR comments and fix failing build * add removal flow * finish edit/remove custom network UI * fix import * remove unused error const * Add translations * add comments * fix isMainnet and isTestnet check for NetworkForm * add Network Settings link to Settings view * rename var and make sure it only triggers in Edit mode * fix some incosistencies in styling Co-authored-by: GitHub Action <action@github.com> * add network invalid msg; fix mainnet/testnet edit ui (#615) * add network invalid msg; fix mainnet/testnet edit ui * Add translations * add show modal helper Co-authored-by: GitHub Action <action@github.com> * remove stellar.expert usage for Custom networks (#616) * remove stellar.expert usage for Custom networks * rm stellar.expert link on view public key * Disable sentry if data sharing not allowed (#618) * Disable sentry if data sharing not allowed * add comment * add copy change * clear up language * Add translations Co-authored-by: GitHub Action <action@github.com> * add active state for active network (#620) * allow editing of active network; fix redirect (#625) * allow editing of active network; fix redirect * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(): bumping release to 2.5.0 (#626) Co-authored-by: GitHub Action <action@github.com> * add changelog (#627) * add a first pass at Experimental Mode and SC parsing (#636) (#637) * add a first pass at Experimental Mode and SC parsing * better var naming * Add translations * use the right SDK when retrieving sourceKeys * use correct SDK for network * rm unused import * rm console Co-authored-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com> * Add translations Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update soroban-client package name * Add translations * use domain when available for isScamAsset calc, change hook to useIsOwnedScamAsset (#652) * use domain when available for isScamAsset calc * use isOwnedScamAsset * use custom error infloblock component (#653) * custom error infloblock * cleanup * cleaning up some UI discrepancies (#654) * cleaning up some UI discrepancies * Add translations Co-authored-by: GitHub Action <action@github.com> * add a check to see if the assets returned exist on our network (#655) * add a check to see if the assets returned exist on our network * check the toml network passphrase to get network * fix adding scam asset with ledger (#656) * qa fixes (#657) * use the force/var (#658) * fix bottom padding of new asset warning modal (#659) * Feature/wal 456 start chrome storage (#661) * first pass at using browser storage * rm comments * add defaultValue * adjust dataStorage API and migrate localStorage to chrome storage on install * add comments * upgrade freighter-api in docs * analytics updates (#663) * finish * fix * cleanup * check for isNewAsset when adding a new asset (#670) * Add translations * Acharb localstorage wrapper (#672) * add localStorage wrapper * PR changes * call it dataStorageAccess * undo merge that made this bug come back :facepalm * fix issues with forgetting to await (#673) * fix issues with forgetting to await * reject with error if we have it * update version name in UI Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Marco Ciaramella <marcociaramella87@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 1, 2024
CassioMG
added a commit
that referenced
this pull request
Aug 11, 2026
Addresses Copilot review on #2933. The explorer action was gated on `!isCustomNetwork`, which only excludes STANDALONE. Experimental mode switches the active network to Futurenet (saveExperimentalFeatures), and stellar.expert has no Futurenet explorer, so the action rendered and built an unsupported /explorer/futurenet/ URL. This is long-standing logic from #616 rather than a regression here, but #2930 removed the QR screen's copy, leaving this the only caller — so it gets fixed here. Note that switching to the shared `getStellarExpertUrl` helper alone does not fix it: the helper falls through to /public for anything that isn't testnet, so an ungated Futurenet link would render a *mainnet* lookup for a Futurenet account — wrong data, silently. The gate is what matters, so this adds `isStellarExpertSupported` beside the helper to keep the two together, with unit tests pinning the Futurenet and custom-network exclusions and documenting that fallback. WalletRow gains `role="button"` and `aria-current`, matching BalanceRow, the sibling list row. The active account was previously conveyed only by the badge on its avatar, which says nothing to a screen reader. Left alone: full keyboard focusability. No row component in this codebase (BalanceRow, ProtocolRow) sets tabIndex or key handlers, so making this one a semantic button would be inconsistent without addressing that codebase-wide. Also adds e2e coverage for the copy action, asserting the clipboard contents and the toast. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CassioMG
added a commit
that referenced
this pull request
Aug 13, 2026
* feat(wallets): refresh the wallets list with an account header Restyle the Wallets screen per node 9573-23172: an active-account header block (identicon, name, address, and four action buttons for QR, copy, stellar.expert, and rename) replaces the per-row ellipsis dropdown. Each WalletRow becomes a three-column row (identicon / name+address / balance) with "Imported" shown inline beside the address. - Copy and stellar.expert buttons add call sites for the existing account.public_key_copied / account.stellar_expert_opened metrics, with no arguments (a `source` property is deferred to a follow-up PR). - The explorer button is hidden via isCustomNetwork(networkDetails), mirroring ViewPublicKey. - Tapping a row still makes that account active and navigates to Home (spec D4) - rename/copy/QR/explorer now act on the active account only. - Removes dead `.detail-indentifier`, `.WalletRow__options-actions`, and `.Wallets__fail` CSS/attribute orphans. - Hand-added new i18n keys to en/pt since build:extension:translations is broken on master (pre-existing, out of scope here). * test(wallets): rename via the account header instead of the row menu The per-row ellipsis dropdown (and its wallet-row-options testid) is gone; rename now acts on the active account through the header pencil button. Repoints "Renames wallets" at wallets-header-edit-name, and scopes its final assertions to the header/row locators specifically since the new name now legitimately renders in two places (and this seed phrase has several accounts sharing the row list). Also updates "Loads wallets data and token prices on Mainnet in batches": address and balance are no longer a single concatenated string, so each per-account assertion now checks a row's balance cell scoped by its address rather than matching literal "address - $balance" text. * fix(wallets): stop the add-wallet button's className from erasing its own styles SDS Button assigns its own className internally and then spreads the rest of its props over the element, so any className passed in by a caller replaces (rather than merges with) Button/Button--tertiary/etc. instead of augmenting them. That silently dropped every rule meant for the restyled add-wallet button, leaving it transparent, gray, and sized off its unconstrained icon/text content. Wrap the Button in a plain div instead and scope the token overrides through that wrapper, targeting `.Button` and `.Button__icon` by descendant selector so they win on specificity without touching the className prop at all. Confirmed via computed-style checks that the button now resolves to the intended lilac-02/09/11 tokens at a 34px pill height, matching the design spec. * fix(wallets): align the wallets screen with the Figma spec Corrects eight deviations from Figma frame 9573-23172: - Header name and address are now one tight block; the 16px gap applies only between the identicon, that block, and the action row. - QR icon qr-code-01 -> qr-code-02, pencil icon edit-05 -> edit-01. - The divider sits inside the 24px content gutter instead of bleeding to the window edges, and is held 16px off the list below it. - Row avatars lose their border and white fill for a flat gray circle, with the identicon inset to 16px inside the 40px avatar. - The active row's selected state drops its colored border in favor of a 16px navy badge flush to the avatar's bottom-right corner. - "Imported" is separated from the address by a bullet. - The add-wallet control keeps its tint on the icon chip alone rather than behind the whole button, at medium weight. The button's copy becomes "Add wallet", which already exists as a key (it is the AddWallet sheet's own title), so this adds no new strings and retires the now-orphaned "Add a wallet". That collision is also why the e2e click moves to the add-wallet testid: the label alone would be ambiguous once the sheet it opens is on screen. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): match the QR screen's copy toast, drop the row hover - The copy button now shows the same success/error toast the QR screen shows, replacing CopyText's inline "Copied!" balloon. The two surfaces do the same thing, so they should confirm it the same way. The metric moves into the handler and fires only after the clipboard write resolves, so failed copies still aren't counted. - Restores SDS's `xl` padding on the add-wallet button. Its 16px/24px text already matches the spec, so only the colors, gap and weight stay overridden; the tint remains on the icon chip alone. - Removes the wallet row's hover background. "Copied!" stays in the catalog — AccountHeader still uses it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): repair the medium font weight, tighten add-wallet spacing `--font-weight-medium` is defined nowhere — not in this repo and not in SDS, which names it `--sds-fw-medium`. An undefined custom property makes the whole declaration invalid, and because font-weight inherits, every element referencing it silently rendered at the body's 400. Measured in a browser before the fix, the add-wallet label, the header name, the row names and the balances were all 400; the spec calls for 500 on each. Swapping the six occurrences in these two files for `--sds-fw-medium` and `--sds-fw-regular` puts them at 500/400 as the spec's Text/MD/500, Text/SM/500 and Text/SM/400 styles require. This also means the earlier "less bold" pass on the add-wallet label was not setting medium at all, only cancelling SDS's semi-bold down to regular by accident. The same undefined token is referenced from BackButton, TransactionHeading, Notification and AmountCard among others, all with the same silent fallback. Those are left alone here. Also drops the add-wallet button's left padding so its icon chip lines up with the list's avatars in the 24px gutter, and gives the content footer an even 8px above and below, scoped with :has() so no other view's footer changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): gate stellar.expert to supported networks, label the row Addresses Copilot review on #2933. The explorer action was gated on `!isCustomNetwork`, which only excludes STANDALONE. Experimental mode switches the active network to Futurenet (saveExperimentalFeatures), and stellar.expert has no Futurenet explorer, so the action rendered and built an unsupported /explorer/futurenet/ URL. This is long-standing logic from #616 rather than a regression here, but #2930 removed the QR screen's copy, leaving this the only caller — so it gets fixed here. Note that switching to the shared `getStellarExpertUrl` helper alone does not fix it: the helper falls through to /public for anything that isn't testnet, so an ungated Futurenet link would render a *mainnet* lookup for a Futurenet account — wrong data, silently. The gate is what matters, so this adds `isStellarExpertSupported` beside the helper to keep the two together, with unit tests pinning the Futurenet and custom-network exclusions and documenting that fallback. WalletRow gains `role="button"` and `aria-current`, matching BalanceRow, the sibling list row. The active account was previously conveyed only by the badge on its avatar, which says nothing to a screen reader. Left alone: full keyboard focusability. No row component in this codebase (BalanceRow, ProtocolRow) sets tabIndex or key handlers, so making this one a semantic button would be inconsistent without addressing that codebase-wide. Also adds e2e coverage for the copy action, asserting the clipboard contents and the toast. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(identicon): drop the now-unused getColorPubKey WalletRow's redesign removed the last caller — it used this to tint the selected row's border, which the new design replaces with a fixed navy badge. The export then had no references anywhere in the repo. `no-unused-vars` cannot see it because the symbol is exported, so it would have stayed green in CI indefinitely rather than surfacing later. Only the getColorPubKey block goes. `publicKeyToBytes` and `HSVtoRGB` stay: drawIdenticon and setFillStyle still call them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
CassioMG
added a commit
that referenced
this pull request
Aug 17, 2026
…ks (#2960) * feat(wallets): refresh the wallets list with an account header Restyle the Wallets screen per node 9573-23172: an active-account header block (identicon, name, address, and four action buttons for QR, copy, stellar.expert, and rename) replaces the per-row ellipsis dropdown. Each WalletRow becomes a three-column row (identicon / name+address / balance) with "Imported" shown inline beside the address. - Copy and stellar.expert buttons add call sites for the existing account.public_key_copied / account.stellar_expert_opened metrics, with no arguments (a `source` property is deferred to a follow-up PR). - The explorer button is hidden via isCustomNetwork(networkDetails), mirroring ViewPublicKey. - Tapping a row still makes that account active and navigates to Home (spec D4) - rename/copy/QR/explorer now act on the active account only. - Removes dead `.detail-indentifier`, `.WalletRow__options-actions`, and `.Wallets__fail` CSS/attribute orphans. - Hand-added new i18n keys to en/pt since build:extension:translations is broken on master (pre-existing, out of scope here). * test(wallets): rename via the account header instead of the row menu The per-row ellipsis dropdown (and its wallet-row-options testid) is gone; rename now acts on the active account through the header pencil button. Repoints "Renames wallets" at wallets-header-edit-name, and scopes its final assertions to the header/row locators specifically since the new name now legitimately renders in two places (and this seed phrase has several accounts sharing the row list). Also updates "Loads wallets data and token prices on Mainnet in batches": address and balance are no longer a single concatenated string, so each per-account assertion now checks a row's balance cell scoped by its address rather than matching literal "address - $balance" text. * fix(wallets): stop the add-wallet button's className from erasing its own styles SDS Button assigns its own className internally and then spreads the rest of its props over the element, so any className passed in by a caller replaces (rather than merges with) Button/Button--tertiary/etc. instead of augmenting them. That silently dropped every rule meant for the restyled add-wallet button, leaving it transparent, gray, and sized off its unconstrained icon/text content. Wrap the Button in a plain div instead and scope the token overrides through that wrapper, targeting `.Button` and `.Button__icon` by descendant selector so they win on specificity without touching the className prop at all. Confirmed via computed-style checks that the button now resolves to the intended lilac-02/09/11 tokens at a 34px pill height, matching the design spec. * fix(wallets): align the wallets screen with the Figma spec Corrects eight deviations from Figma frame 9573-23172: - Header name and address are now one tight block; the 16px gap applies only between the identicon, that block, and the action row. - QR icon qr-code-01 -> qr-code-02, pencil icon edit-05 -> edit-01. - The divider sits inside the 24px content gutter instead of bleeding to the window edges, and is held 16px off the list below it. - Row avatars lose their border and white fill for a flat gray circle, with the identicon inset to 16px inside the 40px avatar. - The active row's selected state drops its colored border in favor of a 16px navy badge flush to the avatar's bottom-right corner. - "Imported" is separated from the address by a bullet. - The add-wallet control keeps its tint on the icon chip alone rather than behind the whole button, at medium weight. The button's copy becomes "Add wallet", which already exists as a key (it is the AddWallet sheet's own title), so this adds no new strings and retires the now-orphaned "Add a wallet". That collision is also why the e2e click moves to the add-wallet testid: the label alone would be ambiguous once the sheet it opens is on screen. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): match the QR screen's copy toast, drop the row hover - The copy button now shows the same success/error toast the QR screen shows, replacing CopyText's inline "Copied!" balloon. The two surfaces do the same thing, so they should confirm it the same way. The metric moves into the handler and fires only after the clipboard write resolves, so failed copies still aren't counted. - Restores SDS's `xl` padding on the add-wallet button. Its 16px/24px text already matches the spec, so only the colors, gap and weight stay overridden; the tint remains on the icon chip alone. - Removes the wallet row's hover background. "Copied!" stays in the catalog — AccountHeader still uses it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): repair the medium font weight, tighten add-wallet spacing `--font-weight-medium` is defined nowhere — not in this repo and not in SDS, which names it `--sds-fw-medium`. An undefined custom property makes the whole declaration invalid, and because font-weight inherits, every element referencing it silently rendered at the body's 400. Measured in a browser before the fix, the add-wallet label, the header name, the row names and the balances were all 400; the spec calls for 500 on each. Swapping the six occurrences in these two files for `--sds-fw-medium` and `--sds-fw-regular` puts them at 500/400 as the spec's Text/MD/500, Text/SM/500 and Text/SM/400 styles require. This also means the earlier "less bold" pass on the add-wallet label was not setting medium at all, only cancelling SDS's semi-bold down to regular by accident. The same undefined token is referenced from BackButton, TransactionHeading, Notification and AmountCard among others, all with the same silent fallback. Those are left alone here. Also drops the add-wallet button's left padding so its icon chip lines up with the list's avatars in the 24px gutter, and gives the content footer an even 8px above and below, scoped with :has() so no other view's footer changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): gate stellar.expert to supported networks, label the row Addresses Copilot review on #2933. The explorer action was gated on `!isCustomNetwork`, which only excludes STANDALONE. Experimental mode switches the active network to Futurenet (saveExperimentalFeatures), and stellar.expert has no Futurenet explorer, so the action rendered and built an unsupported /explorer/futurenet/ URL. This is long-standing logic from #616 rather than a regression here, but #2930 removed the QR screen's copy, leaving this the only caller — so it gets fixed here. Note that switching to the shared `getStellarExpertUrl` helper alone does not fix it: the helper falls through to /public for anything that isn't testnet, so an ungated Futurenet link would render a *mainnet* lookup for a Futurenet account — wrong data, silently. The gate is what matters, so this adds `isStellarExpertSupported` beside the helper to keep the two together, with unit tests pinning the Futurenet and custom-network exclusions and documenting that fallback. WalletRow gains `role="button"` and `aria-current`, matching BalanceRow, the sibling list row. The active account was previously conveyed only by the badge on its avatar, which says nothing to a screen reader. Left alone: full keyboard focusability. No row component in this codebase (BalanceRow, ProtocolRow) sets tabIndex or key handlers, so making this one a semantic button would be inconsistent without addressing that codebase-wide. Also adds e2e coverage for the copy action, asserting the clipboard contents and the toast. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(balances): spinner while pending, $0.00 when unpriced Ports the balance loading/display behavior from freighter-mobile#943. Wallets list rows A row shows a spinner while that account's own total is still pending, instead of the literal "...". Totals arrive in batches of 6, so the guard is per-account (`!accountValue && isFetchingTokenPrices`) rather than the global flag alone — rows 1-6 render real values while 7+ still spin, which is the one frame where this is observable. Once loading settles a total always renders, defaulting to $0.00 rather than an empty cell. The check is falsy rather than `== null` on purpose: the data hook writes "" for an account whose fetch threw, which is equally "no total". `accountValue` is also now optional, which it always was at runtime — Wallets/index.tsx hands `undefined` to a prop typed `string`. Home hero Shows the total whenever account data resolved, defaulting to $0.00 instead of collapsing when nothing is priced. That is every non-Mainnet network (no price feed) and any failed price fetch. No spinner: the extension awaits prices before its first success dispatch, so that window is already covered by the full-screen loader and a hero spinner would be unreachable. `hasError` still yields an empty string. There the balances themselves are unknown, a failure notification is already on screen, and `resolvedData` is null — so $0.00 would be both misleading and unsafe to compute (the `!hasError` short-circuit guards a `resolvedData!`). Token rows are untouched: unpriced tokens keep showing dashes. The assertions at Account.test.tsx:1065-1087 are the regression guard. Also adds `formatFiatAmount`, so the four sites that were assembling `$${formatAmount(roundUsdValue(x))}` share one zero. It coerces non-finite input rather than taking a default parameter, which would have covered `undefined` but let "" through as "$NaN". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(wallets): keep the screen usable when the wallets fetch fails The error branch returned the notification on its own, short-circuiting before SubviewHeader and View.Content. That left the screen with no close button, no account actions and no Add wallet — an error state the user could not navigate out of at all, short of closing the popup. The failure is now scoped to the list region, so the header, the active account block and the footer stay put. `dataState.data` is null in the error state, so the active key falls back to Redux, which still holds it from the last successful load — the chrome never needed the fetch. Also gives the Home error notifications their horizontal gutter. Home disables the content inset (`View.Content hasNoPadding`), so notifications have to bring their own margin or they run edge to edge; `.AccountView__fetch-fail` only set `margin-top`. Sides only, since `margin-top` is what animateNotification animates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(accounts): stop tagging phrase-derived accounts as "Imported" Recovering a wallet probes derivation indices 1..n and pre-loads any that are funded on Mainnet. Those were stored with `imported: true`, so every account but the first came back labelled "Imported" in the wallets list — which is what the user sees, and it is wrong: they are derived from the recovery phrase just taken, exactly like the ones `addAccount` produces from the same phrase, and that path stores them unflagged. "Imported" means an account brought in from a secret key, which the phrase cannot re-derive. Only importAccount should set the flag (plus hardware wallets, which get it from their key-id prefix in getStoredAccounts and are a separate notion). Matches mobile, which drives its label off `importedFromSecretKey`. Note this fixes new recoveries only. `getStoredAccounts` rehydrates the flag from the keystore's `extra.imported` on every unlock, so wallets recovered before this change keep the wrong label until they are recovered again. Correcting those needs a migration that rewrites the keystore, which is only possible while unlocked — deliberately not attempted here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(home): show $0.00 in the hero on error instead of hiding it Drops the last case where the total was hidden. The hero now renders a value whenever the screen does: non-Mainnet networks, a failed price fetch, and now a failed balances fetch alike. This aligns three things that had drifted apart. Mobile's hero has no error branch at all — it renders `formattedBalance`, which is a summed zero when nothing resolved, and surfaces the failure separately in the tokens list. The wallets rows already settle on $0.00 for an account whose fetch failed. Only the extension's hero still collapsed, which made the same underlying failure look different in two places. Safe without the previous `hasError` guard: `balances` already falls back to [] and `tokenPrices` to undefined, so getTotalUsd sums nothing and returns zero without touching the null `resolvedData`. The earlier guard was load-bearing only because the expression used to dereference `resolvedData!.networkDetails`, which this branch removed. The failure is still reported — the "Failed to fetch your account balances." notification is unchanged, and the token rows still show dashes rather than zeros. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(home): repair the fullscreen notice margin and the error identicon Two things that only showed up in the error state. `.AccountView__fullscreen` carried `margin-top: 24px 24px 0`. `margin-top` takes a single value, so the declaration was invalid and dropped whole — the fullscreen notice rendered flush against the window edges with no spacing at all. It now uses the same gutter as `__fetch-fail`, with a bottom margin too so it isn't glued to the content beneath it. The Home header passed `resolvedData?.publicKey || ""` to AccountHeader, and `resolvedData` is null in the error state, so the identicon was handed an empty key and rendered blank. The account *name* kept working because it reads from Redux — hence a named account with no avatar. The key now falls back to Redux as well, which also repairs the header's copy button and account-details link in that state. Same fix the wallets list already had; this is why the identicon showed there but not here. No unit assertion for the identicon: jsdom has no canvas, so createStellarIdenticon().toDataURL() returns one constant for every input, including "". A test would have passed with the bug still in place — confirmed by trying it. Verified in a real browser instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(layout): let the scrollable view fill the window in fullscreen The Home layout's vertical borders stopped partway down the window in fullscreen, leaving the sides unframed below the content. `View--scrollable` set `height: 100%`, which overrides the base `height: 100dvh`. The parent chain (a bare wrapper div, body, html) has no height of its own, so that percentage resolved to `auto` and the layout was only ever as tall as its content. In the popup this is invisible, because the base `min-height` is the popup height — the mismatch only shows once the window is taller than the content. Home is the only view with this class (Router passes isScrollableView for "/"), and it has to be able to grow past the viewport rather than clip like the fixed-height views. So: grow with the content, but never be shorter than it. `View__content` is already `flex: 1`, so it absorbs the slack and the inset borders run the full height. Measured at 900px and 1400px viewports: the layout and the lowest bordered inset now both end exactly at the window bottom, where the layout previously stopped at 602px. Popup dimensions are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(account): one funding action on the unfunded empty state "Add XLM" rendered unconditionally and Friendbot was appended below it, so every test network showed two stacked funding buttons competing for the same job. Where a friendbot exists it is how you fund the account, so it now replaces "Add XLM" rather than sitting under it, and takes the same `secondary` style — it is the primary action of this empty state, not a lesser alternative offered alongside one. Mainnet is unaffected: no friendbot there, so "Add XLM" still renders and still routes to Add Funds. Both e2e consumers stay valid — the login helper drives Friendbot on Testnet, and buyWithOnramp switches to Mainnet before clicking "Add XLM". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * style(account): bump the unfunded funding button one size up md -> lg on both branches of the funding action, so the empty state's only call to action carries more weight. 32px tall becomes 40px with roomier padding; SDS keeps the 14px text across both sizes, so this grows the target without changing the type. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(layout): restore the popup's fixed height floor 24b88d4 replaced the base `min-height: var(--popup--height)` with `min-height: 100dvh` to make the layout fill the window in fullscreen. That regressed the popup: with only a few tokens it opened short. `100dvh` is circular there. Chrome sizes the popup window to the document, so the floor depended on the viewport, which depended on the content, which depended on the floor; a short account settled well under 600px. The fixed `--popup--height` is what broke that cycle, and dropping it removed the only thing holding the popup open. Takes the larger of the two instead, so both cases hold: the fixed floor governs the popup, and 100dvh still wins in fullscreen where the window is taller than the popup height. Measured with a single-token account. Before, a 300px viewport produced a 460px layout; now every viewport at or below 600px produces exactly 600px, and 900px still produces 900px. The original check missed this because it measured at 360x600, where the viewport already equalled the popup height and masked the absent floor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(identicon): drop the now-unused getColorPubKey WalletRow's redesign removed the last caller — it used this to tint the selected row's border, which the new design replaces with a fixed navy badge. The export then had no references anywhere in the repo. `no-unused-vars` cannot see it because the symbol is exported, so it would have stayed green in CI indefinitely rather than surfacing later. Only the getColorPubKey block goes. `publicKeyToBytes` and `HSVtoRGB` stay: drawIdenticon and setFillStyle still call them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(i18n): prune unused keys and finish the pt translations The scanner is configured with `keepRemoved: true` and `removeUnusedKeys: false`, so it only ever adds — unused keys had built up to 92 of 870. Removed 79 of those. The other 13 are used in ways the scanner cannot see, and are kept deliberately: - The four `Authorization *` flag labels live in a bitmask lookup map and reach the UI through `t(label)` (Operations/index.tsx). - Three simulate errors are thrown as Error messages and can be rendered by ErrorBoundary's `t(errorMessage)`. - Six more sit in literal `t()` calls the parser still misses — either nested inside a template literal (ImportAccount) or called through a destructured `t` parameter (muxedAddress). That last group means "the scanner dropped it" is not sufficient on its own, so every candidate was checked against the source: 65 appear nowhere outside the catalogs, and the remaining 14 matched only as substrings of live keys, stale variants (a copy since given a trailing period), comments, or unrelated non-i18n strings. Verified by re-running the scanner in its normal additive mode: it re-added nothing, so no removed key is reachable from source. Also translated the 20 pt entries still sitting in English, following the catalog's own conventions — "flagged as" as "sinalizado como", swap as "troca"/"Trocar", trustline and token left as-is. The 19 that remain identical are brands (Blockaid, Stellar, the network names), tickers and formats (XLM, XDR, wasm), and loanwords standard in pt-BR (dApps, Feedback, Links, Status, Memo, Hash, Salt). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(i18n): drop "Hidden collectibles" again after the merge The conflict resolution on the last master merge restored this key, which 18f381f had removed as unused. It still has no source references — the only nearby matches are tests asserting a different string, "No hidden collectibles". Confirmed by re-running the scanner: it does not re-add the key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(account): colocate the NotFundedMessage test with its component This PR added two tests under components/account/ and placed them inconsistently: WalletRow's sat beside its component, this one a level above in an account/__tests__/ directory the PR itself created. Colocation is the documented rule (testing.md: "Test files live in __tests__/ directories alongside the source they test") and was the only pattern present under account/ — the one pre-existing test there, AccountHeader's, is colocated. The new directory held exactly this file, so leaving it would have made it the precedent for that subtree. A plain move: the file imports through absolute module paths resolved by jest's moduleDirectories, and the default testMatch finds __tests__/ at any depth, so no imports and no config change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(balances): show "--" for an unknown total, "$0.00" only without a feed A missing total has two causes and they deserve different answers. Where the network prices no tokens, zero is the accurate total. Everywhere else an absent total means prices or balances could not be read, and "$0.00" asserts a balance the account may not have — so the hero and the wallets rows now show "--" there, the same thing the token rows show for a token with no price. Mainnet is the only network with a feed, so it alone can produce "--"; the others always read "$0.00", which keeps the common case consistent. WalletRow takes the network's pricing support as a prop rather than inferring it from the empty-string sentinel, so the two cases stay distinguishable at the render site. Also restores the account-data spy before asserting in the ERROR-state test. It ran after, so once that assertion changed, the failure left useGetAccountData mocked for the rest of the file and took three unrelated onboarding tests down with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(home): keep "$0.00" for an unfunded account An account holding nothing has a real total of zero, so the hero shows it even on a network that prices tokens. Without this an unfunded Mainnet account priced nothing, which read as an unavailable total and showed the dash. A failed fetch still shows the dash: funding is unknown there, so zero would be a claim rather than a fact. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(formatters): extract the no-fiat-value placeholder to a constant The "--" shown when a USD amount cannot be determined was duplicated across seven files. Extracted as NO_FIAT_VALUE, next to formatFiatAmount: the two are halves of one decision — format a known amount, or state that there is none — and several call sites already import from there. Its doc records the distinction the duplicated literals could not: the placeholder means "unknown", while "$0.00" asserts a known zero, so an unfunded account or a network that prices no tokens keeps the zero. Comments describing what the user sees still say "--"; they are about the rendered output rather than the symbol. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(balance): replace the total-label ternary chain with early returns Four outcomes nested three ternaries deep did not read as the decision it is. getTotalUsdLabel states each case in order with an early return and a line on why that answer is right, which is where the zero-versus-unknown distinction actually lives. Placed beside getTotalUsd, whose result it formats, so the pair sits together and the branches are unit-testable without rendering the view. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(wallets): decide the row total with getTotalUsdLabel too The rows were not applying a different policy — the decision had already been made a layer up. useGetWalletsData formats each account's total while fetching, so the row received a string and had to infer intent from which flavour of falsy arrived: "" for a failed account, undefined for one not fetched. The hook holds every input the helper wants (isFunded, tokenPrices, the computed total), so it calls getTotalUsdLabel directly and emits a finished label. Off Mainnet it fills one in for every account rather than leaving the map empty, so a missing entry now means exactly one thing: still loading. WalletRow renders what it is handed and no longer takes hasPriceFeed. Its tests drop to spinner-versus-label; which label is right is covered where that is now decided. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(swap): stop a failed price fetch hanging the token picker useGetTokenPrices reports failure by resolving with `tokenPrices: null`. That null reached heldToRecord, whose `tokenPrices: ApiTokenPrices = {}` default only fires on undefined, so it was indexed directly and threw. The throw escaped the lookup's async effect before its success dispatch, leaving the state at LOADING — and the picker counts IDLE and LOADING alike as loading, so "Swap to" span forever instead of falling back to held tokens. Guarded at every step rather than only the one that broke: - useSwapFromData normalizes the fetch result, as useGetSwapAmountData already did; its payload declares the field non-null, so the null was also a type lie. - SwapAsset normalizes at both places it feeds the lookup. The ternary there guarded the payload's type, not a null price map. - heldToRecord, balancesToHeldRecords, buildSwapSections and the lookup accept `ApiTokenPrices | null` and normalize at the leaf, so a future caller cannot reintroduce it. Present on master; not introduced by this branch. Covered by a test on balancesToHeldRecords, which fails on the null case alone if the leaf normalization is removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(balance): correct and clarify the zero-versus-unknown docs formatFiatAmount's doc still named a failed price fetch as a reason to show "$0.00". That case returns the placeholder now, so the doc pointed readers at the wrong answer. It states what the function does — any non-numeric input formats as "$0.00" — and hands the unknown case to NO_FIAT_VALUE. getTotalUsdLabel's zero branch spells out that a bare formatFiatAmount() is "$0.00", which the call alone does not show. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(formatters): correct the stale note on the $0.00 fallback test Same "failed price fetch" claim the formatter's own JSDoc carried: that case renders the placeholder, and only genuinely-zero totals reach formatFiatAmount(). The earlier sweep excluded __tests__, which is how this one survived. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stellar.expert's API relies on either testnet or mainnet. Disable links to stellar.expert and usage of their API for Custom networks