chore(wallets): extract WalletRow, RenameWallet and AddWallet into components - #2929
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-8e3e0781bee67998aacf (SDF collaborators only — install instructions in the release description) |
Contributor
There was a problem hiding this comment.
Pull request overview
Extracts Wallets subcomponents into dedicated account component directories without changing behavior.
Changes:
- Extracts
WalletRow,RenameWallet, andAddWallet. - Moves component-specific styles alongside each component.
- Retains parent-owned overlay and dropdown styles in the Wallets view.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
views/Wallets/index.tsx |
Uses extracted components. |
views/Wallets/styles.scss |
Retains view-level styles. |
components/account/WalletRow/index.tsx |
Defines the extracted wallet row. |
components/account/WalletRow/styles.scss |
Holds wallet-row styles. |
components/account/RenameWallet/index.tsx |
Defines the extracted rename form. |
components/account/RenameWallet/styles.scss |
Holds rename-form styles. |
components/account/AddWallet/index.tsx |
Defines the extracted add-wallet view. |
components/account/AddWallet/styles.scss |
Holds add-wallet styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Contributor
Author
|
Merged this right away since it's pure component extraction verbatim with no behavior change to unblock other work as described on the PR |
This was referenced Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
This is the first step of the Home refresh project. That work redesigns the Home screen plus
six related screens, and it's being split into small, independently reviewable PRs rather than one
large one.
Three of those upcoming PRs each restyle a different piece of the Wallets screen:
The problem: all three of those components currently live in the same 494-line file,
views/Wallets/index.tsx. Three PRs rewriting one file would conflict on every merge, and eachreview would show the other two PRs' churn as noise.
This PR splits that file so those three PRs can each touch a different file and be reviewed on
their own.
What this PR does
Pure extraction — no behavior changes. Nothing about the app changes: same rendered DOM, same
CSS, same props, same analytics. Only which file the code lives in.
Three components move out of
views/Wallets/index.tsxinto their own directories, following theexisting convention of the 28 other components already under
popup/components/account/:Demo sample (no behavior changes)
pr0-code-extraction.mov
Deliberately not done
loadAccount.test.tsflow is the regression guard, and any test written against the ellipsisdropdown would be deleted by the Wallets-list PR, which removes that dropdown.
.Wallets__fail,.detail-indentifier(typo'd, no consumer),.WalletRow__options-actions, and.AddWallet__row-link. Removing them would have changed the compiled CSS and forfeited theequivalence check above. Each is assigned to the follow-up PR that rewrites its area.
'await' has no effectwarnings inviews/Wallets/index.tsxare leftalone. They come from
await dispatch(...)on plaincreateSliceactions and are unchangedfrom
master— only their line numbers shifted. The Wallets-list PR rewrites that exact blockand will clean them up.
Merge note for the follow-ups
The three follow-up PRs each own a different component file, but all three still touch small
regions of
views/Wallets/styles.scss(the two overlay wrapper classes plus the dropdown blockbeing deleted). Merging Wallets list → Rename modal → Add wallet in that order keeps the
rebases trivial.
🤖 Generated with Claude Code