-
Notifications
You must be signed in to change notification settings - Fork 59
✏️ Update network dropdown labels #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
piyalbasu
merged 6 commits into
stellar:master
from
JFWooten4:fix/network-dropdown-labels
Aug 7, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f344697
✏️ Update network dropdown labels
JFWooten4 dc524ed
♻️ Use canonical network names for labels
JFWooten4 71d2047
🧪 Update network label E2E selectors
JFWooten4 0d7c572
🛠️ Stabilize network labels and tests
JFWooten4 2f07b15
Yeah, that was the most aggressive test change
JFWooten4 e872ced
Merge branch 'master' into fix/network-dropdown-labels
piyalbasu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
extension/src/popup/components/account/AccountHeader/__tests__/getNetworkDisplayName.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { NETWORK_NAMES } from "@shared/constants/stellar"; | ||
|
|
||
| import { getNetworkDisplayName } from "../getNetworkDisplayName"; | ||
|
|
||
| const DISPLAY_NAMES = { | ||
| mainnet: "translated-mainnet", | ||
| testnet: "translated-testnet", | ||
| futurenet: "translated-futurenet", | ||
| }; | ||
|
|
||
| describe("getNetworkDisplayName", () => { | ||
| it.each([ | ||
| [NETWORK_NAMES.PUBNET, DISPLAY_NAMES.mainnet], | ||
| [NETWORK_NAMES.TESTNET, DISPLAY_NAMES.testnet], | ||
| [NETWORK_NAMES.FUTURENET, DISPLAY_NAMES.futurenet], | ||
| ])("maps %s to its display name", (networkName, expected) => { | ||
| expect(getNetworkDisplayName(networkName, DISPLAY_NAMES)).toBe(expected); | ||
| }); | ||
|
|
||
| it("preserves custom network names", () => { | ||
| expect(getNetworkDisplayName("My Network", DISPLAY_NAMES)).toBe( | ||
| "My Network", | ||
| ); | ||
| }); | ||
| }); |
23 changes: 23 additions & 0 deletions
23
extension/src/popup/components/account/AccountHeader/getNetworkDisplayName.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { NETWORK_NAMES } from "@shared/constants/stellar"; | ||
|
|
||
| interface NetworkDisplayNames { | ||
| mainnet: string; | ||
| testnet: string; | ||
| futurenet: string; | ||
| } | ||
|
|
||
| export const getNetworkDisplayName = ( | ||
| networkName: string, | ||
| displayNames: NetworkDisplayNames, | ||
| ) => { | ||
| switch (networkName) { | ||
| case NETWORK_NAMES.PUBNET: | ||
| return displayNames.mainnet; | ||
| case NETWORK_NAMES.TESTNET: | ||
| return displayNames.testnet; | ||
| case NETWORK_NAMES.FUTURENET: | ||
| return displayNames.futurenet; | ||
| default: | ||
| return networkName; | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.