[ANCHOR-1206] Carry forward security headers for Gateway API migration - #1940
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores security response headers that were dropped during the Ingress→Gateway API migration, by re-introducing them as Gateway API ResponseHeaderModifier filters on each chart's HTTPRoute. It also adds explicit namespace and sectionName to parentRefs when the chart-managed Gateway is used, for consistency with the existing Gateway API pattern.
Changes:
- Add
httpRoute.responseHeadersvalues key (default{}) to the three Helm charts. - Render a
ResponseHeaderModifierfilter on the HTTPRoute rule whenresponseHeadersis non-empty. - Set
namespace(release namespace) andsectionName(first listener's name) on the chart-managed GatewayparentRefsentry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| helm-charts/sep24-reference-ui/values.yaml | Adds responseHeaders: {} default under httpRoute. |
| helm-charts/sep24-reference-ui/templates/httproute.yaml | Adds namespace/sectionName to chart-managed parentRef and renders ResponseHeaderModifier filter. |
| helm-charts/sep-service/values.yaml | Adds responseHeaders: {} default under httpRoute. |
| helm-charts/sep-service/templates/sepserver-httproute.yaml | Same parentRef + filter additions as above. |
| helm-charts/reference-server/values.yaml | Adds responseHeaders: {} default under httpRoute. |
| helm-charts/reference-server/templates/httproute.yaml | Same parentRef + filter additions as above. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
travertischio
approved these changes
May 14, 2026
marwen-abid
approved these changes
May 14, 2026
amandagonsalves
added a commit
that referenced
this pull request
Jun 8, 2026
### Description Merges `release/4.4.0` into `main` for the 4.4.0 release. ### Context - **[ANCHOR-1215]** Fix SEP-12 IDOR via unvalidated customer `id` — prevents cross-customer KYC disclosure and payout destination overwrite (#1946) - **[ANCHOR-1943]** Fix RPC observer DoS via malformed Soroban transfer event (#1944) - **[ANCHOR-1939]** Add per-client event isolation and ambiguous payment routing safety (#1941, #1942) - **[ANCHOR-1934]** Enforce single-use on SEP-38 quotes (#1935) - **[ANCHOR-1206]** Add Gateway API support to Helm charts and carry forward security headers (#1936, #1940) - **[Chore]** Bump Soroban SDK from v22 to v26 (#1937) - **[Chore]** Bump version to 4.4.0 [ANCHOR-1215]: https://stellarorg.atlassian.net/browse/ANCHOR-1215?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [ANCHOR-1206]: https://stellarorg.atlassian.net/browse/ANCHOR-1206?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
amandagonsalves
added a commit
that referenced
this pull request
Jun 8, 2026
### Description Merges main into `develop` for the 4.4.0 release. ### Context - **[ANCHOR-1215]** Fix SEP-12 IDOR via unvalidated customer `id` — prevents cross-customer KYC disclosure and payout destination overwrite (#1946) - **[ANCHOR-1943]** Fix RPC observer DoS via malformed Soroban transfer event (#1944) - **[ANCHOR-1939]** Add per-client event isolation and ambiguous payment routing safety (#1941, #1942) - **[ANCHOR-1934]** Enforce single-use on SEP-38 quotes (#1935) - **[ANCHOR-1206]** Add Gateway API support to Helm charts and carry forward security headers (#1936, #1940) - **[Chore]** Bump Soroban SDK from v22 to v26 (#1937) - **[Chore]** Bump version to 4.4.0 [ANCHOR-1215]: https://stellarorg.atlassian.net/browse/ANCHOR-1215?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [ANCHOR-1206]: https://stellarorg.atlassian.net/browse/ANCHOR-1206?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
httpRoute.responseHeadersvalues block that emits a Gateway API filter to set security response headersnamespace+sectionNameonparentRefswhen using the chart-managed GatewayContext
The first migration PR dropped the existing
ingress.responseHeadersblock.Adding
namespace+sectionNameonparentRefsis purely a consistency fix to match the established Gateway API pattern.Testing
helm lintpasses for all three charts.helm templatewith Gateway API enabled.Documentation
N/A
Known limitations
N/A