Skip to content

get_discussions_by_blog to filter resteems - #678

Merged
mvandeberg merged 1 commit into
steemit:678-PRfrom
thebitcoiner:581-get_discussions_by_blog-filter-resteems
Dec 14, 2016
Merged

get_discussions_by_blog to filter resteems#678
mvandeberg merged 1 commit into
steemit:678-PRfrom
thebitcoiner:581-get_discussions_by_blog-filter-resteems

Conversation

@thebitcoiner

@thebitcoiner thebitcoiner commented Dec 8, 2016

Copy link
Copy Markdown
Contributor

@mvandeberg

Copy link
Copy Markdown
Contributor

@jcalfee Are these changes to get_state something you want?

@roadscape

Copy link
Copy Markdown
Contributor

@mvandeberg yes. The goal is to allow us to fetch either a pure blog or pure resteemed feed while maintaining backwards-compatibility.

@jcalfee

jcalfee commented Dec 9, 2016

Copy link
Copy Markdown

@mvandeberg I think it is a great idea to split up blogs and resteems this gives authors some freedom to re-steem a lot and still lets users easily find their personal material.

I'm going to have to build this branch before I understand the changes though.

@thebitcoiner

Copy link
Copy Markdown
Contributor Author

Correct, this implementation maintains backwards compatibility. A get_state @user and get_discussions_by_blog functions as it used to. For 6 examples of various usage, see the related steemit post.

@mvandeberg
mvandeberg changed the base branch from develop to 678-PR December 14, 2016 22:22
@mvandeberg
mvandeberg merged commit eeb59d0 into steemit:678-PR Dec 14, 2016
mvandeberg pushed a commit that referenced this pull request Dec 19, 2016
… a more extensible approach and favors numeric comparison to string comparison #678
On1x added a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request Aug 20, 2026
…#678)

service_lazy_withdraw_queue() drained the whole FIFO withdraw queue on every
call — up to 150M rows when free_balance was large — and it was called from
six places, four of them inside evaluators, so one capital-return transaction
could consume unbounded per-block work (one row minted per partial withdrawal
for as little as 1 raw, no floor).

- service_lazy_withdraw_queue(db, row_limit) returns how many rows it
  processed and stops after row_limit.
- Per-transaction call-sites pass 1 (pay the FIFO head; the bulk is drained by
  the cron).
- New cron section 9 drains the queue up to the shared per-block
  pm_settle_rows_per_block row budget whenever pending_withdrawals > 0,
  charging row_budget honestly. This is the liveness backstop: the queue keeps
  progressing even when no capital returns to free_balance.

Test lazy_withdraw_queue_row_budget_spans_blocks: 250 one-raw rows against a
100-row budget span several blocks at <= budget/block, FIFO preserved,
free >= 0, pending -> 0. The honest control (pre-fix unbounded drain) fails
the per-block bound. No layout change -> no testnet redeploy.

docs: settlement-work-bounds 4.8 (queue budget) + lazy-pool guide (the queue
now progresses every block via the cron, not only on capital returns).
On1x added a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request Aug 20, 2026
…/LP fixes)

Bring the docs-only PR for master up to date with the pm-branch docs,
which now carry the steemit#678/steemit#681 documentation:

- settlement-work-bounds.md (new, en-only design note): per-block work
  bounds of PM settlement, GC, void refund, batch-queue and ban sweeps.
- specification.md (en/ru/zh-CN): liquidity_fee_earned is a post-hoc
  counter written in settle_liquidity, not a subtraction in the fee-pool
  formula; early-exit LPs earn no commission; void markets earn zero bonus.
- guides/active-lp.md (en/ru/zh-CN): early exit = principal only, void =
  zero income, pm_min_liquidity floor applies to top-ups.
- guides/lazy-pool.md: FIFO withdraw queue is drained per block; the §9
  cron section shares the row budget.

No node code. Docs tree identical to pm. Docs build verified (26 PM pages).
On1x added a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request Aug 20, 2026
* docs: bring prediction-market documentation to master (en/ru/zh-CN)

* docs: sync docs-pm with current pm docs (settlement-work-bounds, spec/LP fixes)

Bring the docs-only PR for master up to date with the pm-branch docs,
which now carry the steemit#678/steemit#681 documentation:

- settlement-work-bounds.md (new, en-only design note): per-block work
  bounds of PM settlement, GC, void refund, batch-queue and ban sweeps.
- specification.md (en/ru/zh-CN): liquidity_fee_earned is a post-hoc
  counter written in settle_liquidity, not a subtraction in the fee-pool
  formula; early-exit LPs earn no commission; void markets earn zero bonus.
- guides/active-lp.md (en/ru/zh-CN): early exit = principal only, void =
  zero income, pm_min_liquidity floor applies to top-ups.
- guides/lazy-pool.md: FIFO withdraw queue is drained per block; the §9
  cron section shares the row budget.

No node code. Docs tree identical to pm. Docs build verified (26 PM pages).

* docs(pm): sync settlement-work-bounds §4.11–4.12 (cron §6 idle fast-path, deferred-claim purge + phase-1/5 loud signals)

* docs(pm): add Russian translations for early-exit-deferred-claim, parlay-spec, settlement-work-bounds

* docs(pm): add Chinese (zh-CN) translations for early-exit-deferred-claim, parlay-spec, settlement-work-bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants