does not run tests as part of main docker build - #488
Merged
Conversation
Contributor
Author
|
@steemit/steem-develop-committers ping |
Contributor
|
Rebase these into a single commit and I'll merge it. Change first commit to |
Contributor
Author
|
Github lets you squash them on PR merge, afaik. Rebasing as requested. |
sneak
force-pushed
the
sneak/remove-tests-from-prod-build
branch
from
October 7, 2016 00:11
74f1b65 to
389175e
Compare
Contributor
Author
|
ping @theoreticalbts |
mvandeberg
approved these changes
Oct 13, 2016
On1x
pushed a commit
to VIZ-Blockchain/viz-cpp-node
that referenced
this pull request
May 28, 2018
Fix thread name in logging subsystem. steemit#487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
Dockerfileis building both a web node and a p2p node type, the builds on Docker Hub are timing out. This removes the full test build/run in the Dockerfile (which was only there as a sort of belt-and-suspenders approach, as we do the exact same tests before merging todevelopormasteranyway).