Skip to content

does not run tests as part of main docker build - #488

Merged
mvandeberg merged 1 commit into
developfrom
sneak/remove-tests-from-prod-build
Oct 13, 2016
Merged

does not run tests as part of main docker build#488
mvandeberg merged 1 commit into
developfrom
sneak/remove-tests-from-prod-build

Conversation

@sneak

@sneak sneak commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Now that the Dockerfile is building both a web node and a p2p node type, the builds on Docker Hub are timing out. This removes the full test build/run in the Dockerfile (which was only there as a sort of belt-and-suspenders approach, as we do the exact same tests before merging to develop or master anyway).

@sneak

sneak commented Oct 5, 2016

Copy link
Copy Markdown
Contributor Author

@steemit/steem-develop-committers ping

@theoreticalbts

theoreticalbts commented Oct 6, 2016

Copy link
Copy Markdown
Contributor

Rebase these into a single commit and I'll merge it.

git rebase -i  origin/develop

Change first commit to reword and subsequent lines to fixup. Add #488 in the new commit message. Then update the commit date and force-push to this branch to update the PR:

git commit --amend "--date=$(date)"
git push -f origin HEAD:sneak/remove-tests-from-prod-build

@sneak

sneak commented Oct 7, 2016

Copy link
Copy Markdown
Contributor Author

Github lets you squash them on PR merge, afaik. Rebasing as requested.

@sneak
sneak force-pushed the sneak/remove-tests-from-prod-build branch from 74f1b65 to 389175e Compare October 7, 2016 00:11
@sneak

sneak commented Oct 7, 2016

Copy link
Copy Markdown
Contributor Author

ping @theoreticalbts

@mvandeberg
mvandeberg merged commit 7398db2 into develop Oct 13, 2016
@mvandeberg
mvandeberg deleted the sneak/remove-tests-from-prod-build branch October 13, 2016 16:22
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants