dos fix per dan - stop returning results after 20ms runtime - #475
Merged
Conversation
Contributor
|
I'm checking whether excessive iterations in this loop are in fact causing the problem. |
Contributor
|
Too many iterations in this loop are in fact the problem, but the above patch is sub-optimal because it makes the behavior non-deterministic -- it depends on the specifics of timing. |
theoreticalbts
force-pushed
the
20160930-dan-dos-hotfix
branch
from
September 30, 2016 17:49
525f68a to
dcd4165
Compare
Contributor
|
Force-pushed new patch which doesn't depend on timing and logs useful information about failures. |
theoreticalbts
force-pushed
the
20160930-dan-dos-hotfix
branch
from
September 30, 2016 18:02
dcd4165 to
edd1244
Compare
bytemaster
approved these changes
Sep 30, 2016
bytemaster
left a comment
bytemaster
left a comment
Contributor
There was a problem hiding this comment.
This code is acceptable, but should be updated to allow more filtered items by increasing max_itr_count to a constant of 1000.
Contributor
|
Updated to do 10x as many |
On1x
pushed a commit
to VIZ-Blockchain/viz-cpp-node
that referenced
this pull request
May 28, 2018
Merge last fixes from master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.