Skip to content

Fix titlebar should not respond to SystemButton when it is invisible or disabled #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangwenx190 merged 3 commits into from
Oct 12, 2025
Merged

Fix titlebar should not respond to SystemButton when it is invisible or disabled #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc54364
Fix titlebar should not respond to SystemButton when it is invisible …
mengps Oct 11, 2025
13ed854
Add qml Drawer example
mengps Oct 11, 2025
242b4de
Fix only check SystemButton.enabled
mengps Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/qml/FramelessWindow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import QWindowKit 1.0

Window {
property bool showWhenReady: true
property alias titleBar: titleBar

id: window
width: 800
Expand Down
31 changes: 27 additions & 4 deletions examples/qml/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,36 @@ FramelessWindow {
showWhenReady: false
}

Button {
Drawer {
id: drawer
width: 0.66 * parent.width
height: parent.height
edge: Qt.RightEdge
onAboutToShow: titleBar.enabled = false
onAboutToHide: titleBar.enabled = true

Label {
text: "Content goes here!"
anchors.centerIn: parent
}
}

Row {
anchors {
horizontalCenter: parent.horizontalCenter
bottom: parent.bottom
bottomMargin: 20
}
text: qsTr("Open Child Window")
onClicked: childWindow.visible = true
spacing: 10

Button {
text: qsTr("Open Child Window")
onClicked: childWindow.visible = true
}

Button {
text: qsTr("Open Drawer")
onClicked: drawer.visible = true
}
}
}
}
2 changes: 1 addition & 1 deletion src/core/contexts/abstractwindowcontext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ namespace QWK {
*button = WindowAgentBase::Unknown;
for (int i = WindowAgentBase::WindowIcon; i <= WindowAgentBase::Close; ++i) {
auto currentButton = m_systemButtons[i];
if (!currentButton || !m_delegate->isVisible(currentButton)) {
if (!currentButton || !m_delegate->isVisible(currentButton) || !m_delegate->isEnabled(currentButton)) {
continue;
}
if (m_delegate->mapGeometryToScene(currentButton).contains(pos)) {
Expand Down