Skip to content

feat: add SMTD_CHORDAL_HOLD support - #60

Closed
gitbyflux wants to merge 3 commits into
stasmarkin:mainfrom
gitbyflux:main
Closed

gitbyflux wants to merge 3 commits into
stasmarkin:mainfrom
gitbyflux:main

Conversation

@gitbyflux

Copy link
Copy Markdown
Contributor

This implementation was vibecoded — please treat it accordingly.

@stasmarkin

Copy link
Copy Markdown
Owner

Hey! Thank you for you contribution!
Have you tested this on your hardware? And what ai model did you use for this PR?

@gitbyflux

Copy link
Copy Markdown
Contributor Author

Если я правильно понимаю, то вы понимаете русский. Позвольте на русском отвечу.
Я сегодня написал это реализацию с помощью opencode/big-pickle. Да я использую SMTD_CHORDAL_HOLD на своей клавиатуре.

stasmarkin pushed a commit that referenced this pull request Jun 17, 2026
Original chordal-hold implementation by @gitbyflux (PR #60), merged as-is.
Refinements and tests follow in a separate commit.
stasmarkin added a commit that referenced this pull request Jun 17, 2026
Refine the chordal-hold support from #60:
- Resolve handedness via a weak smtd_chordal_handedness(keypos_t) that
  defaults to reading chordal_hold_layout, so keymaps can override it
  without the PROGMEM array and without coupling to QMK's CHORDAL_HOLD.
- Revert the unguarded reorder of the TAP/SEQUENCE steps in the last-state
  SMTD_STAGE_TOUCH branch so non-chordal builds keep the original ordering.
- Keep SMTD_CHORDAL_HOLD a compile-time flag (default 0) so it costs nothing
  when off; all logic stays behind #if SMTD_CHORDAL_HOLD.

Tests:
- Python mocks tests/unit/chordal_hold/ (adds pgm_read_byte to the mock).
- QMK-native tests/integration/suites/smtd_chordal_hold/ against the real
  pipeline + real PROGMEM layout; registered in QMK_ALL_SUITES.

Docs: README feature/config/roadmap notes; AGENTS.md design + test notes.
Bump version to 0.6.3-SNAPSHOT-20260617.
@stasmarkin

Copy link
Copy Markdown
Owner

Thanks @gitbyflux! 🙏 Your implementation is now on main as 509a1b2 (kept under your authorship), with a follow-up refactor + tests in ef4112f:

  • Handedness is now resolved via a weak smtd_chordal_handedness(keypos_t) that defaults to reading chordal_hold_layout, so a keymap can override it without the array (and without coupling to QMK's CHORDAL_HOLD).
  • Reverted the unguarded TAP/SEQUENCE reorder in the last-state SMTD_STAGE_TOUCH branch, so non-chordal builds keep their original ordering.
  • SMTD_CHORDAL_HOLD stays a compile-time flag (default 0, compiles out entirely when off).
  • Added Python-mock tests (tests/unit/chordal_hold/) and a QMK-native suite (tests/integration/suites/smtd_chordal_hold/), plus README/AGENTS notes.

Shipping in v0.6.3-SNAPSHOT. Closing this PR since the work now lives on main (GitHub won't auto-mark it merged because the commit was reworked). Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants