Repository navigation
Conversation
Owner
|
Hey! Thank you for you contribution! |
Contributor
Author
|
Если я правильно понимаю, то вы понимаете русский. Позвольте на русском отвечу. |
stasmarkin
pushed a commit
that referenced
this pull request
Jun 17, 2026
Original chordal-hold implementation by @gitbyflux (PR #60), merged as-is. Refinements and tests follow in a separate commit.
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
Refine the chordal-hold support from #60: - Resolve handedness via a weak smtd_chordal_handedness(keypos_t) that defaults to reading chordal_hold_layout, so keymaps can override it without the PROGMEM array and without coupling to QMK's CHORDAL_HOLD. - Revert the unguarded reorder of the TAP/SEQUENCE steps in the last-state SMTD_STAGE_TOUCH branch so non-chordal builds keep the original ordering. - Keep SMTD_CHORDAL_HOLD a compile-time flag (default 0) so it costs nothing when off; all logic stays behind #if SMTD_CHORDAL_HOLD. Tests: - Python mocks tests/unit/chordal_hold/ (adds pgm_read_byte to the mock). - QMK-native tests/integration/suites/smtd_chordal_hold/ against the real pipeline + real PROGMEM layout; registered in QMK_ALL_SUITES. Docs: README feature/config/roadmap notes; AGENTS.md design + test notes. Bump version to 0.6.3-SNAPSHOT-20260617.
Owner
|
Thanks @gitbyflux! 🙏 Your implementation is now on
Shipping in v0.6.3-SNAPSHOT. Closing this PR since the work now lives on |
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation was vibecoded — please treat it accordingly.