[9/16] Desktop: EditMode tests and test workflow - #28
Draft
richardelms-stash wants to merge 3 commits into
Draft
richardelms-stash wants to merge 3 commits into
richardelms-stash wants to merge 3 commits into
Conversation
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
2 times, most recently
from
August 26, 2026 10:57
5666945 to
af1f375
Compare
richardelms-stash
force-pushed
the
desktop/01-runtime-bridge
branch
from
August 26, 2026 10:58
43d1ce7 to
db8cdbd
Compare
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:58
af1f375 to
72da1a2
Compare
Stash.Unity.Tests.Editor: config struct to desktop JSON serialization and defaults, desktop event name to public event and per-call callback dispatch (dismissed clears the slots, autoClose off delivers failure then success, diagnostics fire nothing), and the vendored native host loading from the package with a repeatable shutdown. test.yml runs EditMode on every push and PR with unity-test-runner.
Only the native-host-load tests stay gated to Windows and macOS editors, so the Linux CI runner executes a non-empty suite.
richardelms-stash
force-pushed
the
desktop/01-runtime-bridge
branch
from
August 26, 2026 10:58
db8cdbd to
f01fcb7
Compare
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:58
72da1a2 to
b991bb4
Compare
The tests passed (11 on Linux) but the job failed publishing the check run: the default token on a pull request cannot create checks.
richardelms-stash
changed the title
Author
|
/ripley review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
stash-unity stack PR 2 of 5 (targets
desktop/01-runtime-bridge, #27). Linear: LAU-299What
Packages/gg.stash.unity/Tests/Editor/(Stash.Unity.Tests.Editor): config struct -> desktop JSON (mobile field names, desktop keys, defaults, null background), desktop event -> public event and per-call callback dispatch throughStashNative.HandleDesktopEvent(dismissed clears the per-call slots,autoClose = falsedelivers failure then success then dismiss,pageLoadedparses invariant ms, diagnostics and processing events fire nothing), and the native host loading from the package with a repeatableShutdown..github/workflows/test.yml:game-ci/unity-test-runner@v4EditMode on every push and PR (Linux runner, so the native-load tests are compiled out there; they ran locally on macOS).Verified
-runTests -testPlatform EditModeon a scratch copy of the project: 15 tests, 15 passed, 0 failed.dotnet format whitespace --verify-no-changesclean.馃 Generated with Claude Code
https://claude.ai/code/session_01FuG7FjNCGRKxPchjZ8AuUV
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.